[GitHub] [hbase] sunhelly commented on a diff in pull request #5258: HBASE-27897 ConnectionImplementation#locateRegionInMeta should pause …

["sunhelly (via GitHub)" <gi...@apache.org>]

sunhelly commented on code in PR #5258:
URL: https://github.com/apache/hbase/pull/5258#discussion_r1212456083


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java:
##########
@@ -1008,9 +1008,11 @@ private RegionLocations locateRegionInMeta(TableName tableName, byte[] row, bool
       }
       // Query the meta region
       long pauseBase = connectionConfig.getPauseMillis();
-      takeUserRegionLock();
       final long lockStartTime = EnvironmentEdgeManager.currentTime();

Review Comment:
   Thanks, you are right. the lockStartTime here marks the timestamp after grabbing the lock(after the takeUserRegionLock() call), while the takeUserRegionLock() has already recorded the lock waiting time. 



##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java:
##########
@@ -1008,9 +1008,11 @@ private RegionLocations locateRegionInMeta(TableName tableName, byte[] row, bool
       }
       // Query the meta region
       long pauseBase = connectionConfig.getPauseMillis();
-      takeUserRegionLock();
       final long lockStartTime = EnvironmentEdgeManager.currentTime();

Review Comment:
   Thanks, you are right. The lockStartTime here marks the timestamp after grabbing the lock(after the takeUserRegionLock() call), while the takeUserRegionLock() has already recorded the lock waiting time. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org