You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/02/03 22:35:39 UTC

[GitHub] [pulsar] addisonj opened a new pull request #6199: [kinesis] Fix netty dependency conflict in Kinesis

addisonj opened a new pull request #6199: [kinesis] Fix netty dependency conflict in Kinesis
URL: https://github.com/apache/pulsar/pull/6199
 
 
   
   
   ### Motivation
   
   The KCL was depending on a version of the aws-sdk-v2 that was relying on
   unstable Netty APIs (see
   aws/aws-sdk-java-v2#1344). Pulsar had taken a
   netty update which was conflicting with their bundled netty and was
   leading to an exception in calling an invalid function.
   
   This newer version of the KCL takes a newer version of aws-sdk-v2 which
   should depend on stable APIs
   
   ### Modifications
   
   Bump some versions
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API: no
     - The schema: (no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? n/a
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] addisonj opened a new pull request #6199: [kinesis] Fix netty dependency conflict in Kinesis

Posted by GitBox <gi...@apache.org>.
addisonj opened a new pull request #6199: [kinesis] Fix netty dependency conflict in Kinesis
URL: https://github.com/apache/pulsar/pull/6199
 
 
   
   
   ### Motivation
   
   The KCL was depending on a version of the aws-sdk-v2 that was relying on
   unstable Netty APIs (see
   aws/aws-sdk-java-v2#1344). Pulsar had taken a
   netty update which was conflicting with their bundled netty and was
   leading to an exception in calling an invalid function.
   
   This newer version of the KCL takes a newer version of aws-sdk-v2 which
   should depend on stable APIs
   
   ### Modifications
   
   Bump some versions
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API: no
     - The schema: (no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? n/a
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] addisonj closed pull request #6199: [kinesis] Fix netty dependency conflict in Kinesis

Posted by GitBox <gi...@apache.org>.
addisonj closed pull request #6199: [kinesis] Fix netty dependency conflict in Kinesis
URL: https://github.com/apache/pulsar/pull/6199
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #6199: [kinesis] Fix netty dependency conflict in Kinesis

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6199: [kinesis] Fix netty dependency conflict in Kinesis
URL: https://github.com/apache/pulsar/pull/6199
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services