You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2013/02/01 11:36:08 UTC
Review Request: [EC2 Query API] In StopInstances add support for parameter
'force'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9245/
-----------------------------------------------------------
Review request for cloudstack and Prachi Damle.
Description
-------
Propagate this parameter to CS to force stop an instance
This addresses bug CLOUDSTACK-1133.
Diffs
-----
awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f
awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java b2451c6
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 17752af
awsapi/src/com/cloud/bridge/service/core/ec2/EC2StopInstances.java 13e23d1
Diff: https://reviews.apache.org/r/9245/diff/
Testing
-------
Run ec2_stop_instances with force set to true - in CS api.log check if parameter 'force' is set to true in stopInstance api call
Thanks,
Likitha Shetty
Re: Review Request: [EC2 Query API] In StopInstances add support for
parameter 'force'
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9245/#review16485
-----------------------------------------------------------
Ship it!
Bug fix looks good.
Commit hash: 33964cf6dab69c486d6801f97ce6354ff2e6a2a2
- Prachi Damle
On Feb. 1, 2013, 10:36 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9245/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 10:36 a.m.)
>
>
> Review request for cloudstack and Prachi Damle.
>
>
> Description
> -------
>
> Propagate this parameter to CS to force stop an instance
>
>
> This addresses bug CLOUDSTACK-1133.
>
>
> Diffs
> -----
>
> awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f
> awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java b2451c6
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 17752af
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2StopInstances.java 13e23d1
>
> Diff: https://reviews.apache.org/r/9245/diff/
>
>
> Testing
> -------
>
> Run ec2_stop_instances with force set to true - in CS api.log check if parameter 'force' is set to true in stopInstance api call
>
>
> Thanks,
>
> Likitha Shetty
>
>