[GitHub] [helix] xyuanlu commented on a change in pull request #1986: Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor

[GitBox <gi...@apache.org>]

xyuanlu commented on a change in pull request #1986:
URL: https://github.com/apache/helix/pull/1986#discussion_r830538331



##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -269,7 +269,10 @@ public ZKHelixManager(String clusterName, String instanceName, InstanceType inst
     }
 
     _stateListener = stateListener;
+    // read cloud config from ZK and set cloudConfig in HelixManagerProperty
     _helixManagerProperty = helixManagerProperty;
+    _helixManagerProperty
+        .setHelixCloudProperty(HelixPropertyFactory.getCloudConfig(_zkAddress, _clusterName));

Review comment:
       `_configAccessor.getCloudConfig()` also returns cloud config. However, _configAccessor is initiated in `connect()` not the zkHelixManager constructor.  So in constructor we need to use `HelixPropertyFactory.getCloudConfig`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org