You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by isapir <gi...@git.apache.org> on 2017/06/10 06:16:32 UTC
[GitHub] tomcat pull request #63: added portOffset attribute to server.xml per BZ-611...
GitHub user isapir opened a pull request:
https://github.com/apache/tomcat/pull/63
added portOffset attribute to server.xml per BZ-61171
https://bz.apache.org/bugzilla/show_bug.cgi?id=61171
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/isapir/tomcat BZ-61171b
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/63.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #63
----
commit f4e487789df9c98082dc18578adcd3fc79d6db49
Author: Igal Sapir <de...@21solutions.net>
Date: 2017-06-10T06:10:26Z
added portOffset attribute to server.xml per BZ-61171
https://bz.apache.org/bugzilla/show_bug.cgi?id=61171
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #63: added portOffset attribute to server.xml per BZ-61171
Posted by isapir <gi...@git.apache.org>.
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/63
Great, I will implement as advised on BZ.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #63: added portOffset attribute to server.xml per BZ-61171
Posted by isapir <gi...@git.apache.org>.
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/63
>I think more discussion is required on how to approach this. Specifically, when should the offset be applied?
@markt-asf I agree, and I was trying to find different options for this in order to initiate a discussion, but the way that Tomcat reads the config files and initializes objects via introspection really limits us here unless there is a major overhaul.
The process is somewhat like this:
1) `Connector`s are initialized (no reference to `Service` or `Server`)
2) `Service` is linked to the `Connector`s (still no reference to `Server`)
3) `Server` is added to Service
Point (3) is point where I took the `portOffset` from Server and applied it to the `Connector`s.
>What is the impact on getters and setters? For example connector.setPort (getPort ()) should be a NO-OP.
At point (1) above the Connector's setPort() is called by the IntrospectionUtils with the values from `server.xml`. That can not be a NO-OP at that point as that would practically disable the Connector, but we can check if `Service` and `Server` are null or not (which they are at initialization) and perhaps do something different accordingly?
Is it even possible/allowed to change the port after initialization?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #63: added portOffset attribute to server.xml per BZ-61171
Posted by powerYao <gi...@git.apache.org>.
Github user powerYao commented on the issue:
https://github.com/apache/tomcat/pull/63
i feel it's not very necessary for tomcat.What if the port is already bound?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #63: added portOffset attribute to server.xml per BZ-61171
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/63
I've added some comments to the bugzilla issue on how this might be addressed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #63: added portOffset attribute to server.xml per BZ-61171
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/63
I think more discussion is required on how to approach this. Specifically, when should the offset be applied? What is the impact on getters and setters? For example connector.setPort (getPort ()) should be a NO-OP. What is reported via JMX? There are all sorts of side effects that need to be thought through here else we'll end up creating some very non-intuative behaviour.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org