You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/09/20 04:19:53 UTC
[GitHub] [maven] lgxbslgx opened a new pull request #546: [MNG-7248] Fix warnings issued by dependency:analyze
lgxbslgx opened a new pull request #546:
URL: https://github.com/apache/maven/pull/546
Hi all,
This patch fixes the warnings issued by `dependency:analyze`. I used the command `mvn dependency:analyze -Drat.skip=true` to analyze my branch `MNG-7248`. There is no warning about `compile` locally. But I didn't use `mvn clean verify` to run the test because the `rat test` failed and other issues occurred locally.
Thanks for taking the time to review.
And should I sign the [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)?
Best Regards,
-- Guoxiong
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #546: [MNG-7248] Fix warnings issued by dependency:analyze
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #546:
URL: https://github.com/apache/maven/pull/546#issuecomment-926439484
This looks really incomplete.
For `maven-core`, I have the following on this PR:
```
INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ maven-core ---
[WARN] Used undeclared dependencies found:
[WARN] org.assertj:assertj-core:jar:2.9.0:test
[WARN] org.hamcrest:hamcrest:jar:2.2:test
[WARN] org.junit.jupiter:junit-jupiter-api:jar:5.7.0:test
[WARN] Unused declared dependencies found:
[WARN] com.google.guava:guava:jar:30.1-jre:compile
[WARN] com.google.guava:failureaccess:jar:1.0.1:compile
[WARN] org.slf4j:slf4j-simple:jar:1.7.32:test
[WARN] org.hamcrest:hamcrest-library:jar:2.2:test
[WARN] org.junit.jupiter:junit-jupiter-engine:jar:5.7.0:test
[WARN] org.hamcrest:hamcrest-core:jar:2.2:test
```
but the other modules display similar warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #546: [MNG-7248] Fix warnings issued by dependency:analyze
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #546:
URL: https://github.com/apache/maven/pull/546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #546: [MNG-7248] Fix warnings issued by dependency:analyze
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #546:
URL: https://github.com/apache/maven/pull/546#issuecomment-924313257
I have dropped the hunks for Guava and Annoations API because it has been handled in another PR (cleanup) already and causes test and runtime failures. Yet another Guice/Guava cleanup must happen in a separate PR.
@rfscholte This looks good to me, no ITs fail. I am willing to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #546: [MNG-7248] Fix warnings issued by dependency:analyze
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #546:
URL: https://github.com/apache/maven/pull/546#issuecomment-926605373
@gnodet This is intentional for two reasons:
* Boris Unckel updated all Google-related deps. I would like to handle futher improvements separately since Guice is a crucial component.
* I have left out test dependencies since they are in different scopes than compile/runtime dependencies. Separate issue/PR as well here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org