[GitHub] [incubator-hop] jballment commented on pull request #858: [HOP-2943] created unit test for only concatenating some fields in the stream

[GitBox <gi...@apache.org>]

jballment commented on pull request #858:
URL: https://github.com/apache/incubator-hop/pull/858#issuecomment-858165443


   Hi,
   
   I've removed the main-004-concat-some-fields.hwf and added the unit test
   into main-004-concat-fields.hwf as requested.
   
   I then squashed the original change with these changes and pushed it to my
   forked repo.  I then went to resubmit the pull request but the existing
   pull request seems to now have the updated version (I'm not sure if that is
   what you were expecting to happen).
   
   Please let me know whether I've submitted this correctly; we don't do "pull
   requests" and "squashing" changes in our environments.
   
   Regards,
   
   *John Ballment*
   Mobile: 0418 740 871
   Email: ***@***.***
   
   Before printing, please consider the environment.
   
   
   On Wed, 9 Jun 2021 at 18:17, Hans Van Akelyen ***@***.***>
   wrote:
   
   > Hi @jballment <https://github.com/jballment> Thanks for the contribution!
   >
   > Can you add the unit test to the existing main-0004-concat-fields.hwf?
   > there is no need to create a workflow per test.
   >
   > We have been using the structure 1 workflow per transform and add multiple
   > test there.
   >
   > Example
   > Wokflow: main-0006-groupby.hwf
   > Unit test pipelines : 0006-groupby-all-rows.hpl, 0006-groupby-basics.hpl,
   > 0006-groupby-no-group.hpl
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-hop/pull/858#issuecomment-857489854>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AA27Y56DK76CEUPBJC7SUZ3TR4PS7ANCNFSM46LP4SMQ>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org