You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/04/04 22:07:50 UTC
[GitHub] [trafficcontrol] shamrickus opened a new pull request, #6719: Fix TPv2 in dev-ciab
shamrickus opened a new pull request, #6719:
URL: https://github.com/apache/trafficcontrol/pull/6719
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
This PR fixes an issue where TPv2 was failing on `npm ci/install` in `alpine`. It also removes an unknown option `--progress` from `ng serve`.
The install is failing because of a [postinstall script from @fortawesome](https://github.com/FortAwesome/Font-Awesome/issues/18803)
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- CDN in a Box
## What is the best way to verify this PR?
Start the TPv2 dev container and verify that it actually serves instead of exiting on `npm ci`.
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
- master
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6719: Fix TPv2 in dev-ciab
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on code in PR #6719:
URL: https://github.com/apache/trafficcontrol/pull/6719#discussion_r842217451
##########
dev/tpv2/run.sh:
##########
@@ -16,5 +16,5 @@
set -o errexit
cd "$TC/experimental/traffic-portal"
-npm ci
-./node_modules/.bin/ng serve --ssl --ssl-cert /server.crt --ssl-key /server.key --watch --progress --proxy-config "$TC/dev/tpv2/proxy.json" --port 443 --host "::0" --live-reload
Review Comment:
`--progress` is "unknown"? I see it in the output of `ng serve --help`:
```
--progress
Log progress to the console while building.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #6719: Fix TPv2 in dev-ciab
Posted by GitBox <gi...@apache.org>.
shamrickus commented on code in PR #6719:
URL: https://github.com/apache/trafficcontrol/pull/6719#discussion_r842220252
##########
dev/tpv2/run.sh:
##########
@@ -16,5 +16,5 @@
set -o errexit
cd "$TC/experimental/traffic-portal"
-npm ci
-./node_modules/.bin/ng serve --ssl --ssl-cert /server.crt --ssl-key /server.key --watch --progress --proxy-config "$TC/dev/tpv2/proxy.json" --port 443 --host "::0" --live-reload
Review Comment:
What version of angular cli are you using? Perhaps your node-modules is out of date (might need to nuke it). I'm using 13.3.1 and `ng seve --help | grep prog` returns nothing
In the TPv2 container:
```
trafficcontrol-tpv2-1 | npm notice
trafficcontrol-tpv2-1 | npm notice New minor version of npm available! 8.5.5 -> 8.6.0
trafficcontrol-tpv2-1 | npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.6.0>
trafficcontrol-tpv2-1 | npm notice Run `npm install -g npm@8.6.0` to update!
trafficcontrol-tpv2-1 | npm notice
trafficcontrol-tpv2-1 | Node.js version v17.8.0 detected.
trafficcontrol-tpv2-1 | Odd numbered Node.js versions will not enter LTS status and should not be used for production. For more information
, please see https://nodejs.org/en/about/releases/.
trafficcontrol-tpv2-1 | Unknown option: '--progress'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #6719: Fix TPv2 in dev-ciab
Posted by GitBox <gi...@apache.org>.
shamrickus commented on code in PR #6719:
URL: https://github.com/apache/trafficcontrol/pull/6719#discussion_r842220252
##########
dev/tpv2/run.sh:
##########
@@ -16,5 +16,5 @@
set -o errexit
cd "$TC/experimental/traffic-portal"
-npm ci
-./node_modules/.bin/ng serve --ssl --ssl-cert /server.crt --ssl-key /server.key --watch --progress --proxy-config "$TC/dev/tpv2/proxy.json" --port 443 --host "::0" --live-reload
Review Comment:
What version of angular cli are you using? Perhaps your node-modules is out of date (might need to nuke it). I'm using 13.3.1 and `ng serve --help | grep prog` returns nothing
In the TPv2 container:
```
trafficcontrol-tpv2-1 | npm notice
trafficcontrol-tpv2-1 | npm notice New minor version of npm available! 8.5.5 -> 8.6.0
trafficcontrol-tpv2-1 | npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.6.0>
trafficcontrol-tpv2-1 | npm notice Run `npm install -g npm@8.6.0` to update!
trafficcontrol-tpv2-1 | npm notice
trafficcontrol-tpv2-1 | Node.js version v17.8.0 detected.
trafficcontrol-tpv2-1 | Odd numbered Node.js versions will not enter LTS status and should not be used for production. For more information
, please see https://nodejs.org/en/about/releases/.
trafficcontrol-tpv2-1 | Unknown option: '--progress'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #6719: Fix TPv2 in dev-ciab
Posted by GitBox <gi...@apache.org>.
ocket8888 merged PR #6719:
URL: https://github.com/apache/trafficcontrol/pull/6719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6719: Fix TPv2 in dev-ciab
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on code in PR #6719:
URL: https://github.com/apache/trafficcontrol/pull/6719#discussion_r843012871
##########
dev/tpv2/run.sh:
##########
@@ -16,5 +16,5 @@
set -o errexit
cd "$TC/experimental/traffic-portal"
-npm ci
-./node_modules/.bin/ng serve --ssl --ssl-cert /server.crt --ssl-key /server.key --watch --progress --proxy-config "$TC/dev/tpv2/proxy.json" --port 443 --host "::0" --live-reload
Review Comment:
I was in a different project directory, which uses Angular 11. In TPv2 I don't see the option anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #6719: Fix TPv2 in dev-ciab
Posted by GitBox <gi...@apache.org>.
shamrickus commented on code in PR #6719:
URL: https://github.com/apache/trafficcontrol/pull/6719#discussion_r842225881
##########
dev/tpv2/run.sh:
##########
@@ -16,5 +16,5 @@
set -o errexit
cd "$TC/experimental/traffic-portal"
-npm ci
-./node_modules/.bin/ng serve --ssl --ssl-cert /server.crt --ssl-key /server.key --watch --progress --proxy-config "$TC/dev/tpv2/proxy.json" --port 443 --host "::0" --live-reload
Review Comment:
Looks like it's deprecated in [Angular 12](https://v12.angular.io/cli/serve) and removed in [Angular 13](https://angular.io/cli/serve). Curiously, `update.angular.io` doesn't list this as a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6719: Fix TPv2 in dev-ciab
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on code in PR #6719:
URL: https://github.com/apache/trafficcontrol/pull/6719#discussion_r843012871
##########
dev/tpv2/run.sh:
##########
@@ -16,5 +16,5 @@
set -o errexit
cd "$TC/experimental/traffic-portal"
-npm ci
-./node_modules/.bin/ng serve --ssl --ssl-cert /server.crt --ssl-key /server.key --watch --progress --proxy-config "$TC/dev/tpv2/proxy.json" --port 443 --host "::0" --live-reload
Review Comment:
I was in a different project directory, which uses Angular 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org