[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s commented on pull request #55: [YUNIKORN-853] Update the value type of node attribute to support Any type

[GitBox <gi...@apache.org>]

wilfred-s commented on pull request #55:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/55#issuecomment-922591646


   Just changing the entry to `google.protobuf.Any` does not fix the problem.
   An `Any` is a  protobuf message which is serialised. It can be any message but still should to be a message. What are we going to store? What is the definition of the message. This is what it says in the [documentation](https://pkg.go.dev/google.golang.org/protobuf@v1.27.1/types/known/anypb):
   > The Any message is a dynamic representation of any other message value. It is functionally a tuple of the full name of the remote message type and the serialized bytes of the remote message value.
   
   Are you proposing to define a non protobuf based serialised version of the map then I do not think that this is the right approach.
   I need a lot more detail on the how and what before we go ahead:
   
   -1 until there is more detail on how this is going to be used


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org