You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/03/24 03:08:35 UTC

[kudu-CR] WIP: cache refactor and persistent support

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2593

to look at the new patch set (#2).

Change subject: WIP: cache refactor and persistent support
......................................................................

WIP: cache refactor and persistent support

TODO:
- the tests run very slowly since they fsync thousands of times
- should split this back up into a refactor and the pmem support
- lots of comments need adjusting
- need tests for the "repopulate" code path.
- there's some sketchy code around pmem_persisting using strlen
- maybe the BlockCache::PendingEntry stuff is somewhat redundant and could
  be written more concisely

Change-Id: Id72570ead662670bf42175756a18ae08d7cd0a07
---
M CMakeLists.txt
A cmake_modules/FindPmem.cmake
D cmake_modules/FindVmem.cmake
M src/kudu/cfile/block_cache-test.cc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/block_cache.h
M src/kudu/cfile/block_handle.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/codegen/code_cache.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
M src/kudu/util/nvm_cache.cc
M thirdparty/build-definitions.sh
16 files changed, 930 insertions(+), 485 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/2593/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id72570ead662670bf42175756a18ae08d7cd0a07
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sarah Jelinek <sj...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>