You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/27 15:51:21 UTC

[GitHub] [arrow] rok commented on pull request #12215: ARROW-14101: [C++] multiply(duration, integer) -> duration kernel

rok commented on pull request #12215:
URL: https://github.com/apache/arrow/pull/12215#issuecomment-1023358897


   > For the `mutiply_checked`, should we add a test for a duration that would go out of bounds? Or is this already sufficiently covered by integer `multiply_checked` tests if that is using the same underlying implementation?
   
   Another test won't hurt :) I'll add it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org