You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/08/11 14:25:04 UTC

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #144: SLING-11396 use the libs folder from appsassembler

kwin commented on PR #144:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/144#issuecomment-1212060562

   > I wonder though if a basic IT which launches the converter ( `ProcessBuilder` / `Runtime.getRuntime().exec` ) just to verify that a simple conversion works would help deal with more delicate changes.
   
   Sounds good, won't have time for that though. I went ahead with merging as a similar fix was pushed to https://github.com/apache/sling-org-apache-sling-feature-launcher/commit/9ee7aeaf66c95b3be82df1c3082bf3e91a7a73de.
   
   It is sad that getting feedback from other committers is so hard...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org