[GitHub] [arrow-datafusion] tiphaineruy commented on a change in pull request #939: fixes #933 replace placeholder fmt_as fr ExecutionPlan impls

[GitBox <gi...@apache.org>]

tiphaineruy commented on a change in pull request #939:
URL: https://github.com/apache/arrow-datafusion/pull/939#discussion_r695467045



##########
File path: datafusion/src/physical_plan/windows/window_agg_exec.rs
##########
@@ -143,6 +143,18 @@ impl ExecutionPlan for WindowAggExec {
         ));
         Ok(stream)
     }
+
+    fn fmt_as(
+        &self,
+        t: DisplayFormatType,
+        f: &mut std::fmt::Formatter,
+    ) -> std::fmt::Result {
+        match t {
+            DisplayFormatType::Default => {
+                write!(f, "WindowAggExec")

Review comment:
       Should be resolved in https://github.com/apache/arrow-datafusion/pull/939/commits/c5e46b131535b21698860f1e2c5aaec40b53c4ce.diff




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org