You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "gavinchou (via GitHub)" <gi...@apache.org> on 2025/11/03 13:41:15 UTC
[PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
gavinchou opened a new pull request, #57653:
URL: https://github.com/apache/doris/pull/57653
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3484334221
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57653_ac8a9e9163ce3a97056b2b087105c7df46901d57_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57653_ac8a9e9163ce3a97056b2b087105c7df46901d57_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.21% (24001/33706) |
| Line Coverage | 57.60% (249382/432985) |
| Region Coverage | 52.33% (205566/392863) |
| Branch Coverage | 54.29% (88770/163496) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3483469154
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou merged PR #57653:
URL: https://github.com/apache/doris/pull/57653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3483602001
<details>
<summary>TPC-DS: <b>Total hot run time: 189925 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ac8a9e9163ce3a97056b2b087105c7df46901d57, data reload: false
query1 1050 417 416 416
query2 6548 1675 1681 1675
query3 6762 229 220 220
query4 27029 23432 23414 23414
query5 4907 600 455 455
query6 335 243 228 228
query7 4655 498 295 295
query8 311 271 248 248
query9 8727 2608 2617 2608
query10 547 347 293 293
query11 15481 15121 14833 14833
query12 182 121 123 121
query13 1696 593 457 457
query14 11298 9365 9367 9365
query15 206 201 176 176
query16 7711 648 531 531
query17 1388 787 641 641
query18 2055 508 369 369
query19 227 234 191 191
query20 136 128 134 128
query21 228 151 127 127
query22 4690 4620 4377 4377
query23 34793 33977 34185 33977
query24 8815 2547 2571 2547
query25 609 509 468 468
query26 1567 286 166 166
query27 2785 524 376 376
query28 4398 2244 2212 2212
query29 802 627 533 533
query30 303 239 223 223
query31 979 799 784 784
query32 84 73 75 73
query33 647 391 343 343
query34 818 854 517 517
query35 806 831 742 742
query36 916 973 895 895
query37 123 110 85 85
query38 3483 3610 3534 3534
query39 1460 1404 1449 1404
query40 218 126 112 112
query41 60 60 58 58
query42 128 115 113 113
query43 467 496 466 466
query44 1223 747 741 741
query45 185 181 175 175
query46 897 991 636 636
query47 1764 1798 1716 1716
query48 396 419 335 335
query49 773 502 420 420
query50 650 702 421 421
query51 3985 3966 3881 3881
query52 105 107 100 100
query53 240 269 198 198
query54 296 285 269 269
query55 86 89 86 86
query56 311 312 303 303
query57 1181 1217 1118 1118
query58 293 288 279 279
query59 2626 2613 2522 2522
query60 350 340 323 323
query61 160 155 152 152
query62 819 735 659 659
query63 229 189 196 189
query64 4446 1187 857 857
query65 4013 3990 3958 3958
query66 1085 441 341 341
query67 15496 15229 15199 15199
query68 9166 891 601 601
query69 493 321 276 276
query70 1326 1248 1323 1248
query71 501 341 312 312
query72 5650 4925 4874 4874
query73 674 566 359 359
query74 8854 9118 8592 8592
query75 4184 3383 2851 2851
query76 3851 1187 754 754
query77 828 420 312 312
query78 9469 9824 8952 8952
query79 2282 832 596 596
query80 789 567 516 516
query81 483 260 232 232
query82 421 157 131 131
query83 294 263 254 254
query84 305 118 99 99
query85 907 472 431 431
query86 345 322 291 291
query87 3721 3756 3649 3649
query88 3147 2269 2229 2229
query89 389 330 299 299
query90 2033 216 209 209
query91 160 177 137 137
query92 82 67 63 63
query93 1568 993 652 652
query94 687 444 343 343
query95 411 331 318 318
query96 497 598 285 285
query97 2958 2992 2884 2884
query98 245 213 206 206
query99 1431 1412 1296 1296
Total cold run time: 280190 ms
Total hot run time: 189925 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3483609850
<details>
<summary>ClickBench: <b>Total hot run time: 28.23 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ac8a9e9163ce3a97056b2b087105c7df46901d57, data reload: false
query1 0.06 0.04 0.04
query2 0.10 0.05 0.04
query3 0.26 0.08 0.08
query4 1.61 0.12 0.11
query5 0.27 0.26 0.26
query6 1.15 0.66 0.65
query7 0.03 0.03 0.03
query8 0.06 0.05 0.05
query9 0.60 0.54 0.52
query10 0.60 0.60 0.59
query11 0.16 0.11 0.11
query12 0.15 0.13 0.12
query13 0.63 0.61 0.60
query14 0.99 1.02 1.01
query15 0.85 0.84 0.84
query16 0.40 0.40 0.41
query17 1.01 1.01 1.07
query18 0.22 0.20 0.21
query19 1.92 1.87 1.83
query20 0.02 0.01 0.01
query21 15.47 0.18 0.14
query22 5.11 0.06 0.04
query23 15.66 0.26 0.10
query24 2.57 1.27 0.93
query25 0.08 0.06 0.05
query26 0.15 0.12 0.14
query27 0.07 0.06 0.05
query28 5.14 1.15 0.94
query29 12.67 3.92 3.25
query30 0.28 0.13 0.12
query31 2.83 0.60 0.38
query32 3.23 0.57 0.47
query33 3.05 3.00 3.08
query34 15.79 5.18 4.64
query35 4.59 4.66 4.62
query36 0.69 0.51 0.50
query37 0.10 0.07 0.07
query38 0.07 0.04 0.05
query39 0.04 0.03 0.03
query40 0.18 0.15 0.13
query41 0.09 0.03 0.04
query42 0.04 0.04 0.04
query43 0.04 0.04 0.04
Total cold run time: 99.03 s
Total hot run time: 28.23 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3480590940
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #57653:
URL: https://github.com/apache/doris/pull/57653#discussion_r2488430489
##########
be/test/olap/segment_writer_full_encode_keys_test.cpp:
##########
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <gtest/gtest.h>
+
+#include <string>
+#include <vector>
+
+#include "olap/key_coder.h"
+#include "olap/olap_common.h"
+#include "olap/rowset/segment_v2/segment_writer.h"
+#include "util/key_util.h"
+#include "util/slice.h"
+#include "vec/common/string_container.h" // hex_dump
Review Comment:
```suggestion
#include "vec/common/string_view.h" // hex_dump
```
##########
be/test/olap/segment_writer_full_encode_keys_test.cpp:
##########
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <gtest/gtest.h>
+
+#include <string>
+#include <vector>
+
+#include "olap/key_coder.h"
+#include "olap/olap_common.h"
+#include "olap/rowset/segment_v2/segment_writer.h"
+#include "util/key_util.h"
+#include "util/slice.h"
+#include "vec/common/string_container.h" // hex_dump
+#include "vec/olap/olap_data_convertor.h"
+
+namespace doris {
+namespace segment_v2 {
+using namespace doris::vectorized;
+
+auto create_string_accessor(const std::vector<std::string>& str) {
+ ColumnString::MutablePtr column = ColumnString::create();
+ // ASSERT_TRUE(!str.empty());
+ for (auto& s : str) column->insert_value(s);
+ DataTypePtr data_type =
+ DataTypeFactory::instance().create_data_type(FieldType::OLAP_FIELD_TYPE_VARCHAR, 0, 0);
+ ColumnWithTypeAndName typed_column(column->get_ptr(), data_type, "test_string_column");
+
+ // Create a VARCHAR convertor, a convertor is an accessor
+ auto convertor =
+ std::make_shared<OlapBlockDataConvertor::OlapColumnDataConvertorVarChar>(false);
+ convertor->set_source_column(typed_column, 0, str.size()); // row_pos=0, num_rows=str.size()
+
+ // Convert to OLAP format
+ auto status = convertor->convert_to_olap();
+ EXPECT_TRUE(status.ok());
+ if (status.ok()) {
+ // Get the converted data
+ const void* data = convertor->get_data_at(0);
+ // const UInt8* nullmap = convertor->get_nullmap();
+ std::cout << ((StringRef*)data)->to_string() << std::endl;
+ std::cout << column->get_data_at(0) << std::endl;
+ // Use the converted data as needed
+ }
+ return convertor;
+}
+
+auto create_int_accessor(const std::vector<PrimitiveTypeTraits<TYPE_BIGINT>::CppType>& values) {
+ // ASSERT_TRUE(!values.empty());
+ auto column = ColumnInt64::create();
+ for (auto value : values) column->insert_value(value);
+ DataTypePtr data_type = DataTypeFactory::instance().create_data_type(TYPE_INT, 0, 0);
+ ColumnWithTypeAndName typed_column(column->get_ptr(), data_type, "test_int_column");
+ auto convertor =
+ std::make_shared<OlapBlockDataConvertor::OlapColumnDataConvertorSimple<TYPE_BIGINT>>();
+ convertor->set_source_column(typed_column, 0,
+ values.size()); // row_pos=0, num_rows=values.size()
+ auto status = convertor->convert_to_olap();
+ EXPECT_TRUE(status.ok());
+ return convertor;
+}
+
+TEST(SegmentWriterFullEncodeKeysTest, TestSegmentWriterKeyEncoding) {
+ // 2 rows of key columns(int,string,string), expect encode bytes of row1 < row2
+ // 0x05050505, a, bb
+ // 0x05050505, a\x01, cc
+ // however the ending byte of 2nd row is \x01 (smaller than KEY_NORMAL_MARKER)
+ // will be in reversed order after encoding
+ auto int_accessor = create_int_accessor({0x05050505, 0x05050505});
+ auto str_accessor0 = create_string_accessor({"a", "a\x01"});
+ auto str_accessor1 = create_string_accessor({"bb", "cc"});
+ std::vector<vectorized::IOlapColumnDataAccessor*> key_columns = {
+ int_accessor.get(), str_accessor0.get(), str_accessor1.get()};
+ auto int_coder = get_key_coder(FieldType::OLAP_FIELD_TYPE_INT);
+ auto str_coder = get_key_coder(FieldType::OLAP_FIELD_TYPE_VARCHAR);
+ std::vector<const KeyCoder*> key_coders = {int_coder, str_coder, str_coder};
+ ////////////////////////////////////////////////////////////////////////////
+ std::string encoded0 = SegmentWriter::_full_encode_keys(key_coders, key_columns, 0);
+ std::string encoded1 = SegmentWriter::_full_encode_keys(key_coders, key_columns, 1);
+ ////////////////////////////////////////////////////////////////////////////
+ std::cout << StringContainer(encoded0).dump_hex() << std::endl; // X'02850505050261026262'
+ std::cout << StringContainer(encoded1).dump_hex() << std::endl; // X'0285050505026101026363'
Review Comment:
```suggestion
std::cout << StringView(encoded0).dump_hex() << std::endl; // X'02850505050261026262'
std::cout << StringView(encoded1).dump_hex() << std::endl; // X'0285050505026101026363'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3480880064
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3481064922
<details>
<summary>ClickBench: <b>Total hot run time: 27.82 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2069580adc569f56f4aed2e91a9c5f87c2158946, data reload: false
query1 0.05 0.05 0.06
query2 0.10 0.05 0.05
query3 0.25 0.08 0.08
query4 1.61 0.13 0.12
query5 0.27 0.26 0.25
query6 1.20 0.64 0.65
query7 0.04 0.02 0.03
query8 0.06 0.04 0.04
query9 0.60 0.53 0.53
query10 0.58 0.59 0.57
query11 0.16 0.12 0.11
query12 0.15 0.13 0.12
query13 0.63 0.61 0.60
query14 1.01 1.00 1.02
query15 0.88 0.85 0.85
query16 0.40 0.40 0.38
query17 1.05 1.03 1.05
query18 0.22 0.20 0.21
query19 1.98 1.88 1.78
query20 0.02 0.01 0.02
query21 15.45 0.19 0.13
query22 5.11 0.08 0.05
query23 15.66 0.25 0.10
query24 2.35 0.48 1.31
query25 0.08 0.07 0.07
query26 0.15 0.15 0.13
query27 0.06 0.05 0.06
query28 5.40 1.18 0.94
query29 12.56 4.01 3.30
query30 0.28 0.13 0.12
query31 2.82 0.62 0.39
query32 3.23 0.55 0.51
query33 3.06 3.13 3.06
query34 15.77 5.21 4.61
query35 4.67 4.59 4.69
query36 0.70 0.51 0.49
query37 0.10 0.07 0.07
query38 0.06 0.04 0.04
query39 0.04 0.03 0.02
query40 0.17 0.14 0.14
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.04
Total cold run time: 99.15 s
Total hot run time: 27.82 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3480592470
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3483312025
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57653_2069580adc569f56f4aed2e91a9c5f87c2158946_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57653_2069580adc569f56f4aed2e91a9c5f87c2158946_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.47% (24062/33668) |
| Line Coverage | 57.83% (250193/432602) |
| Region Coverage | 52.73% (206978/392490) |
| Branch Coverage | 54.58% (89121/163295) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3484531224
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3483669329
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/ac8a9e9163ce3a97056b2b087105c7df46901d57_ac8a9e9163ce3a97056b2b087105c7df46901d57/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/ac8a9e9163ce3a97056b2b087105c7df46901d57_ac8a9e9163ce3a97056b2b087105c7df46901d57/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.72% (18056/34249) |
| Line Coverage | 38.01% (164163/431856) |
| Region Coverage | 32.38% (125267/386894) |
| Branch Coverage | 33.78% (54782/162186) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3481489343
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57653_2069580adc569f56f4aed2e91a9c5f87c2158946_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57653_2069580adc569f56f4aed2e91a9c5f87c2158946_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.47% (24062/33668) |
| Line Coverage | 57.83% (250193/432602) |
| Region Coverage | 52.73% (206978/392490) |
| Branch Coverage | 54.58% (89121/163295) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3481227314
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2069580adc569f56f4aed2e91a9c5f87c2158946_2069580adc569f56f4aed2e91a9c5f87c2158946/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2069580adc569f56f4aed2e91a9c5f87c2158946_2069580adc569f56f4aed2e91a9c5f87c2158946/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.72% (18056/34249) |
| Line Coverage | 38.01% (164150/431857) |
| Region Coverage | 32.34% (125135/386894) |
| Branch Coverage | 33.77% (54768/162186) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3480933914
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](UT) Add UT for SegmentWriter::_full_encode_keys [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57653:
URL: https://github.com/apache/doris/pull/57653#issuecomment-3480933716
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org