You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/23 12:38:44 UTC

[jira] [Commented] (GEARPUMP-280) max timestamp should be less than LifeTime.death

    [ https://issues.apache.org/jira/browse/GEARPUMP-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880354#comment-15880354 ] 

ASF GitHub Bot commented on GEARPUMP-280:
-----------------------------------------

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/159

    [GEARPUMP-280] Set MAX_TIME_MILLIS to Long.MaxValue minus 1

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump GEARPUMP-280

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #159
    
----
commit 664819c9028f02f6083b04a396ce2e755f9de59e
Author: manuzhang <ow...@gmail.com>
Date:   2017-02-23T10:56:17Z

    [GEARPUMP-280] Set MAX_TIME_MILLIS to Long.MaxValue minus 1

----


> max timestamp should be less than LifeTime.death
> ------------------------------------------------
>
>                 Key: GEARPUMP-280
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-280
>             Project: Apache Gearpump
>          Issue Type: Bug
>            Reporter: Manu Zhang
>
> LifeTime.death is now {{Long.MaxValue}} in milliseconds, which prohibits message with that timestamp to be sent out. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)