You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2014/05/21 18:10:01 UTC
[GitHub] incubator-storm pull request: STORM-216: Added Authentication and ...
GitHub user revans2 opened a pull request:
https://github.com/apache/incubator-storm/pull/121
STORM-216: Added Authentication and Authorization.
This is an upmerged version of https://github.com/yahoo/incubator-storm/tree/security
Most of the documentation for this should be in SECURITY.md. The documentation may not be perfect and if you have any questions while trying to set this up please ask them on the pull request so that I can clean up the documentation and make it complete.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-storm security
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit fe5f41aa8332700d3f98422cb7d986fc47289bcd
Author: Robert (Bobby) Evans <bo...@apache.org>
Date: 2014-05-21T16:03:11Z
STORM-216: Added Authentication and Authorization.
This is an upmerged version of https://github.com/yahoo/incubator-storm/tree/security
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-216: Added Authentication and ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/121#issuecomment-45912041
This pull request has been up for 3 weeks without a single comment yet. I know it is a huge patch, but any feedback on it would be appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-216: Added Authentication and ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/121#issuecomment-45763838
Just upmerged to the latest master. This was not that trivial because of the UI changes that switched over to using templates and AJAX. The only part I did not bring over was displaying the logged in user on the UI page. I am going to continue to work on this, and should hopefully have that up soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-216: Added Authentication and ...
Posted by miguno <gi...@git.apache.org>.
Github user miguno commented on the pull request:
https://github.com/apache/incubator-storm/pull/121#issuecomment-50666328
Thanks for the follow-up, Bobby.
FYI: I learned about the IPv6 timing issue on Mac OS X in the meantime, and I also updated the JVM configuration settings (i.e. disabling IPv6) in Storm-based projects such as [kafka-storm-starter](https://github.com/miguno/kafka-storm-starter).
Do you think we should add this to the Storm docs? (I took me hours to track this issue down, for instance, and only after I found a fix myself did I read your "Heureka" comment in one of the Storm issues/pull requests.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-216: Added Authentication and ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/121#issuecomment-50641173
@miguno wow it took me a month to respond to your comment, I am really sorry. I resolved STORM-146 originally pointing to this branch as the fix, because the tests all pass on ZK 3.4.5 here. The fix is related to IPv6 timing out on the mac and causing issues. When we added in a config to the pom to ask it to favor IPv4 when running the tests everything was fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-216: Added Authentication and ...
Posted by miguno <gi...@git.apache.org>.
Github user miguno commented on the pull request:
https://github.com/apache/incubator-storm/pull/121#issuecomment-47404034
Bobby, do you know what the relation of this (big) ticket is to [STORM-146](https://issues.apache.org/jira/browse/STORM-146), which is marked as "contained by" this ticket?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-216: Added Authentication and ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/121#issuecomment-44408880
Just upmerged to the latest master, and pulled in a test fix. Be aware that on a Mac (which has a case insensitive file system) the update may not go that cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-216: Added Authentication and ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/121#issuecomment-50685964
Yes, lets put it in the documentation. For most systems a 1 second delay every so often is not a big deal, but with storm being near real time it can be a big impact., not just for tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---