[GitHub] [iceberg] danielcweeks commented on pull request #1099: Combine ManifestReaders into one parameterized class

[GitBox <gi...@apache.org>]

danielcweeks commented on pull request #1099:
URL: https://github.com/apache/iceberg/pull/1099#issuecomment-641470306


   +1  This looks good to me.  I would point out that it's confusing in a number of places where it's necessary to distinguish between `deleteManifests` and `deletedManifests`, but I'm not sure what we can do to be more clear about the distinction.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org