Change in hyracks[master]: ASTERIXDB-1058: Lazy LSM memory components allocation

["Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1058: Lazy LSM memory components allocation
......................................................................


Patch Set 1:

(3 comments)

I think that we can (and should) avoid the extension of the IIndexLifecyleManager.

Also, it could increase readability (at least for me) to have private methods to clear, search, or validate the in-memory components in the different LSMTrees - similar to the private deallocateMemoryComponents method that they all have.

https://asterix-gerrit.ics.uci.edu/#/c/405/1/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IIndexLifecycleManager.java
File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IIndexLifecycleManager.java:

Line 40:     public void deallocateMemory(long resourceID) throws HyracksDataException;
It seems that we don't need to extend the interface here, as there is only one implementation of this interface that actually needs these methods.


https://asterix-gerrit.ics.uci.edu/#/c/405/1/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexLifecycleManager.java
File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexLifecycleManager.java:

Line 249:     public void allocateMemory(long resourceID) throws HyracksDataException {
This method is only used internally and could thus be private.


Line 271:     public void deallocateMemory(long resourceID) throws HyracksDataException {
ditto


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I476e756f8d71260ea614c8c072fc9503053866c9
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Young-Seok Kim <ki...@gmail.com>
Gerrit-HasComments: Yes