You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/04/21 03:17:31 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1443: [CELEBORN-540][Refactor] Add config entity of celeborn.rpc.io.threads
AngersZhuuuu opened a new pull request, #1443:
URL: https://github.com/apache/incubator-celeborn/pull/1443
### What changes were proposed in this pull request?
Add config entity of celeborn.rpc.io.threads
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1443: [CELEBORN-540][Refactor] Add config entity of celeborn.rpc.io.threads
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1443:
URL: https://github.com/apache/incubator-celeborn/pull/1443#discussion_r1173264085
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1071,6 +1072,16 @@ object CelebornConf extends Logging {
.timeConf(TimeUnit.MILLISECONDS)
.createWithDefaultString("10s")
+ val RPC_IO_THREAD: OptionalConfigEntry[Int] =
+ buildConf("celeborn.rpc.io.threads")
+ .withAlternative("rss.rpc.io.threads")
+ .categories("network")
+ .doc("Netty IO thread number of NettyRpcEnv to handle RPC request. " +
+ s"The default threads number is the number of runtime available processors.")
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1443: [CELEBORN-540][Refactor] Add config entity of celeborn.rpc.io.threads
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1443:
URL: https://github.com/apache/incubator-celeborn/pull/1443#discussion_r1173263426
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1071,6 +1072,16 @@ object CelebornConf extends Logging {
.timeConf(TimeUnit.MILLISECONDS)
.createWithDefaultString("10s")
+ val RPC_IO_THREAD: OptionalConfigEntry[Int] =
+ buildConf("celeborn.rpc.io.threads")
+ .withAlternative("rss.rpc.io.threads")
+ .categories("network")
+ .doc("Netty IO thread number of NettyRpcEnv to handle RPC request. " +
+ s"The default threads number is the number of runtime available processors.")
Review Comment:
remove leading `s`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1443: [CELEBORN-540][Refactor] Add config entity of celeborn.rpc.io.threads
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu merged PR #1443:
URL: https://github.com/apache/incubator-celeborn/pull/1443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org