[GitHub] [spark] srowen commented on a change in pull request #24212: [SPARK-26771][SQL][FOLLOWUP] Make all the uncache operations non-blocking by default

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24212: [SPARK-26771][SQL][FOLLOWUP] Make all the uncache operations non-blocking by default
URL: https://github.com/apache/spark/pull/24212#discussion_r268919541
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala
 ##########
 @@ -103,7 +103,7 @@ class CacheManager extends Logging {
   def uncacheQuery(
       query: Dataset[_],
       cascade: Boolean,
-      blocking: Boolean = true): Unit = {
 
 Review comment:
   Why even keep the parameter? This is internal to Spark right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org