[jira] [Commented] (HADOOP-13438) Optimize IPC server protobuf decoding

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406006#comment-15406006 ] 

Hadoop QA commented on HADOOP-13438:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  4s{color} | {color:red} HADOOP-13438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12820809/HADOOP-13438.patch |
| JIRA Issue | HADOOP-13438 |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/10166/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Optimize IPC server protobuf decoding
> -------------------------------------
>
>                 Key: HADOOP-13438
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13438
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-13438.patch
>
>
> The current use of the protobuf API uses an expensive code path.  The builder uses the parser to instantiate a message, then copies the message into the builder.  The parser is creating multi-layered internally buffering streams that cause excessive byte[] allocations.
> Using the parser directly with a coded input stream backed by the byte[] from the wire will take a fast-path straight to the pb message's ctor.  Substantially less garbage is generated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org