You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by vistep <gi...@git.apache.org> on 2017/08/08 16:32:11 UTC
[GitHub] zeppelin pull request #2521: [ZEPPELIN-2841] fix a problem in shell interpre...
GitHub user vistep opened a pull request:
https://github.com/apache/zeppelin/pull/2521
[ZEPPELIN-2841] fix a problem in shell interpreter . Working directory '.' can not be found in docker envi
### What is this PR for?
shell interpreter complained that working directory '.' can not be found in docker environment.
I add a line of code to set current working directory to USER`s home, and it works.
### What type of PR is it?
Bug Fix
### Todos
* tests
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2841
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vistep/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2521.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2521
----
commit d02104ac58a85e6e70704a57ed43ae6a32bb0b61
Author: 束佳明 <sh...@hotmail.com>
Date: 2017-08-05T07:50:50Z
Merge pull request #1 from apache/master
merge apache/zeppelin
commit e8cbdd180a22d1d53366c94c5432c217d70a5727
Author: Shu Jiaming <ji...@transwarp.io>
Date: 2017-08-08T16:25:15Z
ZEPPELIN-2841 fix a bug where shell interpreter complained that working directory '.' cna not be found in docker enviroment.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...
Posted by vistep <gi...@git.apache.org>.
Github user vistep commented on the issue:
https://github.com/apache/zeppelin/pull/2521
I replaced System.getenv("HOME") with System.getProperty("user.home") .
This time, Jenkins said "[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:yarn (yarn test) on project zeppelin-web: Failed to run task: 'yarn run test' failed. (error code 1) -> [Help 1]"
I don`t understand why my code affects zeppelin-web ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...
Posted by sanjaydasgupta <gi...@git.apache.org>.
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2521
I have not looked at the code in detail, so will refrain from making suggestions about the code :-)
---
[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...
Posted by vistep <gi...@git.apache.org>.
Github user vistep commented on the issue:
https://github.com/apache/zeppelin/pull/2521
I tried again and it passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...
Posted by vistep <gi...@git.apache.org>.
Github user vistep commented on the issue:
https://github.com/apache/zeppelin/pull/2521
Can we use a try-catch block to test if we need to set working directory when zeppelin opens a shell interpreter?
---
[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...
Posted by vistep <gi...@git.apache.org>.
Github user vistep commented on the issue:
https://github.com/apache/zeppelin/pull/2521
@Leemoonsoo How about the idea above?
---
[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2521
@sanjaydasgupta @vistep have create JIRA for the same https://issues.apache.org/jira/browse/ZEPPELIN-2903.
---
[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2521
LGTM and merge to master and branch-0.7 if no further comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2521: [ZEPPELIN-2841] fix a problem in shell interpre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2521
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...
Posted by vistep <gi...@git.apache.org>.
Github user vistep commented on the issue:
https://github.com/apache/zeppelin/pull/2521
Jenkins said that "Can't find build for commit e8cbdd180a22d1d53366c94c5432c217d70a5727 from vistep".
I have no idea about what happened. How to fix it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...
Posted by vistep <gi...@git.apache.org>.
Github user vistep commented on the issue:
https://github.com/apache/zeppelin/pull/2521
I have fix the build problem by setting travis according to what Jenkins said at last part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...
Posted by sanjaydasgupta <gi...@git.apache.org>.
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2521
This implementation has a harmful side effect that can break existing notebooks.
The problem with this fix is that it changes the meaning of all relative path-names used in any shell commands. For example, after this fix, the command `ls -l data` would operate on the _data_ subdirectory of the user's home directory, whereas before the fix it would operate on the _data_ subdirectory of zeppelin's working directory.
One immediate change that is suggested is to change the fix to make it apply only to the narrow situation it is needed in (a Docker environment).
---
[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2521
build sometimes fail because of network connection problem of flaky tests.
Could you try restart failed one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---