You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2015/06/16 09:51:34 UTC

[Bug 7212] New: Warning of uninitialized value in Mail::SpamAssassin::PerMsgStatus::get_names_of_tests_hit_with_scores()

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7212

            Bug ID: 7212
           Summary: Warning of uninitialized value in
                    Mail::SpamAssassin::PerMsgStatus::get_names_of_tests_h
                    it_with_scores()
           Product: Spamassassin
           Version: 3.4.1
          Hardware: PC
                OS: FreeBSD
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Libraries
          Assignee: dev@spamassassin.apache.org
          Reporter: franz@electromail.org

Created attachment 5308
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5308&action=edit
patch for PerMsgStatus::get_names_of_tests_hit_with_scores()

Using Mail::SpamAssassin::PerMsgStatus::get_names_of_tests_hit_with_scores()
results in:

Use of uninitialized value $line in string ne at
/usr/local/lib/perl5/site_perl/Mail/SpamAssassin/PerMsgStatus.pm line 770.

$line should be initialized with ''. Patch attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7212] Warning of uninitialized value in Mail::SpamAssassin::PerMsgStatus::get_names_of_tests_hit_with_scores()

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7212

--- Comment #3 from Kevin A. McGrail <km...@pccc.com> ---
I'm +1 if you want to apply.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7212] Warning of uninitialized value in Mail::SpamAssassin::PerMsgStatus::get_names_of_tests_hit_with_scores()

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7212

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.4.2

--- Comment #4 from Mark Martinec <Ma...@ijs.si> ---
> I'm +1 if you want to apply.

trunk:
Bug 7212: code compaction (was: Warning of uninitialized value)
  Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Committed revision 1685857.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7212] Warning of uninitialized value in Mail::SpamAssassin::PerMsgStatus::get_names_of_tests_hit_with_scores()

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7212

--- Comment #2 from Mark Martinec <Ma...@ijs.si> ---
Created attachment 5309
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5309&action=edit
A more compact alternative

A more radical coding approach (attached) reduces the number of
generated opcodes in affected code sections by 40 % (132 > 79 opcodes)
according to B::Concise.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7212] Warning of uninitialized value in Mail::SpamAssassin::PerMsgStatus::get_names_of_tests_hit_with_scores()

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7212

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |kmcgrail@pccc.com

--- Comment #1 from Kevin A. McGrail <km...@pccc.com> ---
Fixed on trunk and 3.4 branch, thanks.

svn commit -m 'Fixed uninitialized error with $line - Thanks to Franz Schwartau
bug 7212 - trunk'
Sending        lib/Mail/SpamAssassin/PerMsgStatus.pm
Transmitting file data .
Committed revision 1685842.

svn commit -m 'Fixed uninitialized error with $line - Thanks to Franz Schwartau
bug 7212 - 3.4' lib/
Sending        lib/Mail/SpamAssassin/PerMsgStatus.pm
Transmitting file data .
Committed revision 1685843.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7212] Warning of uninitialized value in Mail::SpamAssassin::PerMsgStatus::get_names_of_tests_hit_with_scores()

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7212

Sidney Markowitz <si...@sidney.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sidney@sidney.com

--- Comment #5 from Sidney Markowitz <si...@sidney.com> ---
Ported the change from comment 4 to branch 3.4
Committed revision 1791580

-- 
You are receiving this mail because:
You are the assignee for the bug.