You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ashishvijaywargiya (via GitHub)" <gi...@apache.org> on 2026/08/16 09:52:34 UTC
[PR] Move misplaced order promotion labels to error bundle, fix test data field typos [ofbiz-framework]
ashishvijaywargiya opened a new pull request, #1660:
URL: https://github.com/apache/ofbiz-framework/pull/1660
ProductPromoWorker looks up OrderNoAgreementFoundWithIdNotDoingPromotions and OrderNoAgreementItemFoundForAgreementWithIdNotDoingPromotions from the OrderErrorUiLabels bundle, but both were only defined in OrderUiLabels, causing missing-label warnings at runtime. Moved them to the correct file.
Also fixed two test fixture typos found via the same testIntegration run:
- AgreementTerm test data had a productId attribute that isn't a real field on that entity.
- Invoice test data used currencyUom instead of the actual field name currencyUomId.
Verified by re-running testIntegration: build stays successful, no suite regressions, and the missing-label/invalid-field warnings are gone from the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move misplaced order promotion labels to error bundle, fix test data field typos [ofbiz-framework]
Posted by "ashishvijaywargiya (via GitHub)" <gi...@apache.org>.
ashishvijaywargiya merged PR #1660:
URL: https://github.com/apache/ofbiz-framework/pull/1660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org