[GitHub] [tvm] adstraw commented on a diff in pull request #15684: [Hopper TMA] Add intrinsic to create barriers for synchronization

["adstraw (via GitHub)" <gi...@apache.org>]

adstraw commented on code in PR #15684:
URL: https://github.com/apache/tvm/pull/15684#discussion_r1319140645


##########
src/target/source/codegen_cuda.h:
##########
@@ -109,6 +109,13 @@ class CodeGenCUDA final : public CodeGenC {
   // Op attribute map
   OpAttrMap<bool> op_need_warp_shuffle_ = Op::GetAttrMap<bool>("cuda.need_warp_shuffle");
 
+  // The name of the barrier array in shared memory
+  const std::string barrier_name_ = "barrier";

Review Comment:
   Good point.  Scoping is kernel scope.  Let's leave this for now and address problems as they come up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org