You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by chao an <ma...@gmail.com> on 2025/04/07 09:13:02 UTC

Vote for rename modlib to libelf

Hi community,

Some green hand and individual developer who are not familiar with nuttx
may be confused by the naming of modlib, in currect implement, modlib as an
elf loader and parser, does not provide any features other than elf.

In this pull request, I plan to rename modlib to elf, and adjust it from
the architecture level as follows:

https://github.com/apache/nuttx/pull/15765


[image: image.png]

In addition from other popular operating systems, different loadable types
are all implemented in binfmt. Therefore, it is also impossible for modlib
to support formats other than ELF in the future:

https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c

This is where they belong:
https://github.com/apache/nuttx/tree/master/binfmt


So I need your vote here:
If you prefer modlib, please reply with -1.
If you recommend libelf, please reply with +1.

BRs,

Re: Vote for rename modlib to libelf

Posted by chao an <ma...@gmail.com>.
@sebastien
Thanks for your opinion. I think I need to add more information to make
everyone clear about the purpose of this change.

BRs,

Sebastien Lorquet <se...@lorquet.fr> 于2025年4月7日周一 21:39写道:

> There was a lot of comments in the github and I may have missed the whole
> of it.
>
> Your information was reassuring, I am not opposing it anymore.
>
> Care is being taken about this issue, that is the most important of all.
>
> Sebastien
>
>
> On 07/04/2025 15:35, chao an wrote:
>
> @ Sebastien Lorquet
>
> > - breaks several build you had to fix incrementally
> > However, I see a genuine concern from many members around this change,
> actual tests are being made and additional required fixes have been found.
> > Also communication efforts have been made beforehand.
>
>
> This commit does not bring any side effects, because the PR has been
> pending for too long, and the nutxx and apps repositories need to be
> rebased. You can ask @lupyuen further, he knows the details
>
>
> > - it fixes nothing not the name.
>
> This is not a simple renaming, but a matter of correcting history
> (apache/nuttx#14100):
>
> NuttX have 2 elf implementations before, one is libelf and other one is
> modlib, 90% of the code was duplicated. Modlib has more features than
> libelf, including dynamic loading, so the libelf code was completely
> deleted in the following commit:
> apache/nuttx#14100
> but actually modlib is the implementation of elf. In this PR, I changed
> the name of modlib back to libelf, so that readers can know more clearly
> what the internal implementation is
>
>
> > Also why is the commit showing the name as "ELF" and not "LIBELF"?
>
> The default name has been changed to libelf
>
>
> I'm not sure why you object to this change, and I want to try to convince
> you further.
>
> Sebastien Lorquet <se...@lorquet.fr> 于2025年4月7日周一 21:12写道:
>
>> Hello,
>>
>>
>> This rename:
>>
>> - breaks several build you had to fix incrementally
>>
>> - it fixes nothing not the name.
>>
>>
>> The modlib name is unfortunate but I think we can live with it.
>>
>>
>> Also why is the commit showing the name as "ELF" and not "LIBELF"?
>>
>> That is not acceptable for me. Also -1.
>>
>>
>> However, I see a genuine concern from many members around this change,
>> actual tests are being made and additional required fixes have been found.
>>
>> Also communication efforts have been made beforehand.
>>
>> I am grateful for this.
>>
>>
>> Best regards,
>>
>> Sebastien
>>
>>
>> On 07/04/2025 11:13, chao an wrote:
>>
>> Hi community,
>>
>> Some green hand and individual developer who are not familiar with nuttx
>> may be confused by the naming of modlib, in currect implement, modlib as an
>> elf loader and parser, does not provide any features other than elf.
>>
>> In this pull request, I plan to rename modlib to elf, and adjust it from
>> the architecture level as follows:
>>
>> https://github.com/apache/nuttx/pull/15765
>>
>>
>> [image: image.png]
>>
>> In addition from other popular operating systems, different loadable
>> types are all implemented in binfmt. Therefore, it is also impossible for
>> modlib to support formats other than ELF in the future:
>>
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
>>
>> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>>
>> This is where they belong:
>> https://github.com/apache/nuttx/tree/master/binfmt
>>
>>
>> So I need your vote here:
>> If you prefer modlib, please reply with -1.
>> If you recommend libelf, please reply with +1.
>>
>> BRs,
>>
>>

Re: Vote for rename modlib to libelf

Posted by Sebastien Lorquet <se...@lorquet.fr>.
There was a lot of comments in the github and I may have missed the 
whole of it.

Your information was reassuring, I am not opposing it anymore.

Care is being taken about this issue, that is the most important of all.

Sebastien


On 07/04/2025 15:35, chao an wrote:
> @ Sebastien Lorquet
>
>
> > - breaks several build you had to fix incrementally
> > However, I see a genuine concern from many members around this 
> change, actual tests are being made and additional required fixes have 
> been found.
> > Also communication efforts have been made beforehand.
>
>
> This commit does not bring any side effects, because the PR has been 
> pending for too long, and the nutxx and apps repositories need to be 
> rebased. You can ask @lupyuen further, he knows the details
>
>
> > - it fixes nothing not the name.
>
> This is not a simple renaming, but a matter of correcting history 
> (apache/nuttx#14100):
>
> NuttX have 2 elf implementations before, one is libelf and other one 
> is modlib, 90% of the code was duplicated. Modlib has more features 
> than libelf, including dynamic loading, so the libelf code was 
> completely deleted in the following commit:
> apache/nuttx#14100
> but actually modlib is the implementation of elf. In this PR, I 
> changed the name of modlib back to libelf, so that readers can know 
> more clearly what the internal implementation is
>
>
> > Also why is the commit showing the name as "ELF" and not "LIBELF"?
>
> The default name has been changed to libelf
>
>
> I'm not sure why you object to this change, and I want to try to 
> convince you further.
>
> Sebastien Lorquet <se...@lorquet.fr> 于2025年4月7日周一 21:12写道:
>
>     Hello,
>
>
>     This rename:
>
>     - breaks several build you had to fix incrementally
>
>     - it fixes nothing not the name.
>
>
>     The modlib name is unfortunate but I think we can live with it.
>
>
>     Also why is the commit showing the name as "ELF" and not "LIBELF"?
>
>     That is not acceptable for me. Also -1.
>
>
>     However, I see a genuine concern from many members around this
>     change, actual tests are being made and additional required fixes
>     have been found.
>
>     Also communication efforts have been made beforehand.
>
>     I am grateful for this.
>
>
>     Best regards,
>
>     Sebastien
>
>
>     On 07/04/2025 11:13, chao an wrote:
>>     Hi community,
>>
>>     Some green hand and individual developer who are not familiar
>>     with nuttx may be confused by the naming of modlib, in currect
>>     implement, modlib as an elf loader and parser, does not provide
>>     any features other than elf.
>>
>>     In this pull request, I plan to rename modlib to elf, and adjust
>>     it from the architecture level as follows:
>>
>>     https://github.com/apache/nuttx/pull/15765
>>
>>
>>     image.png
>>
>>     In addition from other popular operating systems, different
>>     loadable types are all implemented in binfmt. Therefore, it is
>>     also impossible for modlib to support formats other than ELF in
>>     the future:
>>
>>     https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
>>     https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
>>     https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
>>     https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
>>     https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
>>     https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>>
>>     This is where they belong:
>>     https://github.com/apache/nuttx/tree/master/binfmt
>>
>>
>>     So I need your vote here:
>>     If you prefer modlib, please reply with -1.
>>     If you recommend libelf, please reply with +1.
>>
>>     BRs,
>

Re: Vote for rename modlib to libelf

Posted by chao an <ma...@gmail.com>.
@ Sebastien Lorquet

> - breaks several build you had to fix incrementally
> However, I see a genuine concern from many members around this change,
actual tests are being made and additional required fixes have been found.
> Also communication efforts have been made beforehand.


This commit does not bring any side effects, because the PR has been
pending for too long, and the nutxx and apps repositories need to be
rebased. You can ask @lupyuen further, he knows the details


> - it fixes nothing not the name.

This is not a simple renaming, but a matter of correcting history
(apache/nuttx#14100):

NuttX have 2 elf implementations before, one is libelf and other one is
modlib, 90% of the code was duplicated. Modlib has more features than
libelf, including dynamic loading, so the libelf code was completely
deleted in the following commit:
apache/nuttx#14100
but actually modlib is the implementation of elf. In this PR, I changed the
name of modlib back to libelf, so that readers can know more clearly what
the internal implementation is


> Also why is the commit showing the name as "ELF" and not "LIBELF"?

The default name has been changed to libelf


I'm not sure why you object to this change, and I want to try to convince
you further.

Sebastien Lorquet <se...@lorquet.fr> 于2025年4月7日周一 21:12写道:

> Hello,
>
>
> This rename:
>
> - breaks several build you had to fix incrementally
>
> - it fixes nothing not the name.
>
>
> The modlib name is unfortunate but I think we can live with it.
>
>
> Also why is the commit showing the name as "ELF" and not "LIBELF"?
>
> That is not acceptable for me. Also -1.
>
>
> However, I see a genuine concern from many members around this change,
> actual tests are being made and additional required fixes have been found.
>
> Also communication efforts have been made beforehand.
>
> I am grateful for this.
>
>
> Best regards,
>
> Sebastien
>
>
> On 07/04/2025 11:13, chao an wrote:
>
> Hi community,
>
> Some green hand and individual developer who are not familiar with nuttx
> may be confused by the naming of modlib, in currect implement, modlib as an
> elf loader and parser, does not provide any features other than elf.
>
> In this pull request, I plan to rename modlib to elf, and adjust it from
> the architecture level as follows:
>
> https://github.com/apache/nuttx/pull/15765
>
>
> [image: image.png]
>
> In addition from other popular operating systems, different loadable types
> are all implemented in binfmt. Therefore, it is also impossible for modlib
> to support formats other than ELF in the future:
>
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>
> This is where they belong:
> https://github.com/apache/nuttx/tree/master/binfmt
>
>
> So I need your vote here:
> If you prefer modlib, please reply with -1.
> If you recommend libelf, please reply with +1.
>
> BRs,
>
>

Re: Vote for rename modlib to libelf

Posted by Sebastien Lorquet <se...@lorquet.fr>.
Hello,


This rename:

- breaks several build you had to fix incrementally

- it fixes nothing not the name.


The modlib name is unfortunate but I think we can live with it.


Also why is the commit showing the name as "ELF" and not "LIBELF"?

That is not acceptable for me. Also -1.


However, I see a genuine concern from many members around this change, 
actual tests are being made and additional required fixes have been found.

Also communication efforts have been made beforehand.

I am grateful for this.


Best regards,

Sebastien


On 07/04/2025 11:13, chao an wrote:
> Hi community,
>
> Some green hand and individual developer who are not familiar with 
> nuttx may be confused by the naming of modlib, in currect implement, 
> modlib as an elf loader and parser, does not provide any features 
> other than elf.
>
> In this pull request, I plan to rename modlib to elf, and adjust it 
> from the architecture level as follows:
>
> https://github.com/apache/nuttx/pull/15765
>
>
> image.png
>
> In addition from other popular operating systems, different loadable 
> types are all implemented in binfmt. Therefore, it is also impossible 
> for modlib to support formats other than ELF in the future:
>
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>
> This is where they belong:
> https://github.com/apache/nuttx/tree/master/binfmt
>
>
> So I need your vote here:
> If you prefer modlib, please reply with -1.
> If you recommend libelf, please reply with +1.
>
> BRs,

Re: Vote for rename modlib to libelf

Posted by chao an <ma...@gmail.com>.
Hi community,

I believe we have reached a consensus in this mail thread. Please allow me
to end the current vote. The final result is:
+1: 9
+0: 3
-1: 0
Thanks everyone for your valuable comments.

cc @lupyuen

BRs,

chao an <ma...@gmail.com> 于2025年4月7日周一 17:13写道:

> Hi community,
>
> Some green hand and individual developer who are not familiar with nuttx
> may be confused by the naming of modlib, in currect implement, modlib as an
> elf loader and parser, does not provide any features other than elf.
>
> In this pull request, I plan to rename modlib to elf, and adjust it from
> the architecture level as follows:
>
> https://github.com/apache/nuttx/pull/15765
>
>
> [image: image.png]
>
> In addition from other popular operating systems, different loadable types
> are all implemented in binfmt. Therefore, it is also impossible for modlib
> to support formats other than ELF in the future:
>
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>
> This is where they belong:
> https://github.com/apache/nuttx/tree/master/binfmt
>
>
> So I need your vote here:
> If you prefer modlib, please reply with -1.
> If you recommend libelf, please reply with +1.
>
> BRs,
>

Re: Vote for rename modlib to libelf

Posted by Gregory Nutt <sp...@gmail.com>.
> > > If you prefer modlib, please reply with -1.
> > > If you recommend libelf, please reply with +1.

Rules for voting are a little different for code changes.

The required Apache voting process is here:  https://www.apache.org/foundation/voting.html

For code changes, that document says:  "Votes on code modifications follow consensus approval<https://www.apache.org/foundation/glossary.html#ConsensusApproval>. In this scenario, a negative vote constitutes a veto<https://www.apache.org/foundation/voting.html#Veto>, which the voting group (generally the PMC of a project) cannot override. Again, this model may be modified by a lazy consensus<https://www.apache.org/foundation/voting.html#LazyConsensus> declaration when the request for a vote is raised, but the full-stop nature of a negative vote does not change. Under normal (non-lazy consensus) conditions, the proposal requires three +1 votes and no -1 votes in order to pass; if it fails to garner the requisite amount of support, it doesn't. Then the proposer either withdraws the proposal or modifies the code and resubmits it, or the proposal simply languishes as an open issue until someone gets around to removing it."
And "For code-modification votes, +1 votes are in favour of the proposal, but -1 votes are vetos<https://www.apache.org/foundation/voting.html#Veto> and kill the proposal dead until all vetoers withdraw their -1 votes.
Unless the proposer declares that the vote is using lazy consensus<https://www.apache.org/foundation/voting.html#LazyConsensus>, three +1 votes are required for a code-modification proposal to pass."


Re: Vote for rename modlib to libelf

Posted by Nathan Hartman <ha...@gmail.com>.
+1

On Tue, Apr 8, 2025 at 8:55 AM Tiago Medicci Serrano
<ti...@gmail.com> wrote:
>
> +1
>
> Em seg., 7 de abr. de 2025 às 21:16, Yanfeng Liu <yf...@qq.com.invalid>
> escreveu:
>
> > +1
> > On Mon, 2025-04-07 at 17:13 +0800, chao an wrote:
> > > Hi community,
> > >
> > > Some green hand and individual developer who are not familiar with nuttx
> > > may be confused by the naming of modlib, in currect implement, modlib as
> > an
> > > elf loader and parser, does not provide any features other than elf.
> > >
> > > In this pull request, I plan to rename modlib to elf, and adjust it from
> > > the architecture level as follows:
> > >
> > > https://github.com/apache/nuttx/pull/15765
> > >
> > >
> > > [image: image.png]
> > >
> > > In addition from other popular operating systems, different loadable
> > types
> > > are all implemented in binfmt. Therefore, it is also impossible for
> > modlib
> > > to support formats other than ELF in the future:
> > >
> > > https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> > > https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> > > https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> > > https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> > > https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> > >
> > https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
> > >
> > > This is where they belong:
> > > https://github.com/apache/nuttx/tree/master/binfmt
> > >
> > >
> > > So I need your vote here:
> > > If you prefer modlib, please reply with -1.
> > > If you recommend libelf, please reply with +1.
> > >
> > > BRs,
> >
> >

Re: Vote for rename modlib to libelf

Posted by Tiago Medicci Serrano <ti...@gmail.com>.
+1

Em seg., 7 de abr. de 2025 às 21:16, Yanfeng Liu <yf...@qq.com.invalid>
escreveu:

> +1
> On Mon, 2025-04-07 at 17:13 +0800, chao an wrote:
> > Hi community,
> >
> > Some green hand and individual developer who are not familiar with nuttx
> > may be confused by the naming of modlib, in currect implement, modlib as
> an
> > elf loader and parser, does not provide any features other than elf.
> >
> > In this pull request, I plan to rename modlib to elf, and adjust it from
> > the architecture level as follows:
> >
> > https://github.com/apache/nuttx/pull/15765
> >
> >
> > [image: image.png]
> >
> > In addition from other popular operating systems, different loadable
> types
> > are all implemented in binfmt. Therefore, it is also impossible for
> modlib
> > to support formats other than ELF in the future:
> >
> > https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> > https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> > https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> > https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> > https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> >
> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
> >
> > This is where they belong:
> > https://github.com/apache/nuttx/tree/master/binfmt
> >
> >
> > So I need your vote here:
> > If you prefer modlib, please reply with -1.
> > If you recommend libelf, please reply with +1.
> >
> > BRs,
>
>

Re: Vote for rename modlib to libelf

Posted by Yanfeng Liu <yf...@qq.com.INVALID>.
+1
On Mon, 2025-04-07 at 17:13 +0800, chao an wrote:
> Hi community,
> 
> Some green hand and individual developer who are not familiar with nuttx
> may be confused by the naming of modlib, in currect implement, modlib as an
> elf loader and parser, does not provide any features other than elf.
> 
> In this pull request, I plan to rename modlib to elf, and adjust it from
> the architecture level as follows:
> 
> https://github.com/apache/nuttx/pull/15765
> 
> 
> [image: image.png]
> 
> In addition from other popular operating systems, different loadable types
> are all implemented in binfmt. Therefore, it is also impossible for modlib
> to support formats other than ELF in the future:
> 
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
> 
> This is where they belong:
> https://github.com/apache/nuttx/tree/master/binfmt
> 
> 
> So I need your vote here:
> If you prefer modlib, please reply with -1.
> If you recommend libelf, please reply with +1.
> 
> BRs,


Re: Vote for rename modlib to libelf

Posted by Tomek CEDRO <to...@cedro.info>.
Hello world :-)

Sorry for a bit of absence I was out for a delegation getting back to
the living :-)

0 from me not to block as there is a preference towards change and it
seems remaining part of the bigger update in progress that should be
closed.. if the community prefers to have it in the minor update (not
13.0) so be it :-)

@anchao thank you for good problem description and discussion / vote
on the mailing list! As this is breaking change this approach seems to
work well and prevent surprises after release is made :-)

Here are some references to LibELF approaches from FreeBSD, its not
part of libc but a contrib/elftoolchain, maybe could provide some
inspiration :-)

https://wiki.freebsd.org/LibElf
https://sourceforge.net/p/elftoolchain/wiki/Home/
https://svnweb.freebsd.org/base/head/contrib/elftoolchain/
https://sourceforge.net/p/elftoolchain/wiki/libelf/

Thank you :-)
Tomek



On Mon, Apr 7, 2025 at 9:13 AM chao an <ma...@gmail.com> wrote:
>
> Hi community,
>
> Some green hand and individual developer who are not familiar with nuttx may be confused by the naming of modlib, in currect implement, modlib as an elf loader and parser, does not provide any features other than elf.
>
> In this pull request, I plan to rename modlib to elf, and adjust it from the architecture level as follows:
>
> https://github.com/apache/nuttx/pull/15765
>
>
>
>
> In addition from other popular operating systems, different loadable types are all implemented in binfmt. Therefore, it is also impossible for modlib to support formats other than ELF in the future:
>
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>
> This is where they belong:
> https://github.com/apache/nuttx/tree/master/binfmt
>
>
> So I need your vote here:
> If you prefer modlib, please reply with -1.
> If you recommend libelf, please reply with +1.
>
> BRs,



-- 
CeDeROM, SQ7MHZ, http://www.tomek.cedro.info

Re: Vote for rename modlib to libelf

Posted by "Lee, Lup Yuen" <lu...@appkaki.com>.
+1

Lup

On Mon, Apr 7, 2025 at 5:13 PM chao an <ma...@gmail.com> wrote:

> Hi community,
>
> Some green hand and individual developer who are not familiar with nuttx
> may be confused by the naming of modlib, in currect implement, modlib as an
> elf loader and parser, does not provide any features other than elf.
>
> In this pull request, I plan to rename modlib to elf, and adjust it from
> the architecture level as follows:
>
> https://github.com/apache/nuttx/pull/15765
>
>
> [image: image.png]
>
> In addition from other popular operating systems, different loadable types
> are all implemented in binfmt. Therefore, it is also impossible for modlib
> to support formats other than ELF in the future:
>
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>
> This is where they belong:
> https://github.com/apache/nuttx/tree/master/binfmt
>
>
> So I need your vote here:
> If you prefer modlib, please reply with -1.
> If you recommend libelf, please reply with +1.
>
> BRs,
>

Re: Vote for rename modlib to libelf

Posted by Takashi Yamamoto <ya...@midokura.com.INVALID>.
On Wed, Apr 9, 2025 at 9:22 AM Tomek CEDRO <to...@cedro.info> wrote:
>
> Hi Takashi :-)
>
> There were long discussions on the mailing list, then voting, then
> discussion on the PR, and comes after lots of breaking changes being
> too freely merged into the upstream, sometimes with laconic
> description and sometimes without even testing. This is to focus more
> on long term self-compatibility and maintenance and improve overall
> pr/commit/code quality. As you can see we are testing "new process" of
> breaking changes processing.. more attention is given to breaking
> stuff.. pr/commits descriptions are better.. we have discussions on
> the mailing list prior breaking change is merged, and it is still
> possible to introduce breaking stuff, but more carefully. Please take
> a look at mailing list archives.

are you suggesting that i'm misunderstanding the text in CONTRIBUTING.md?

>
> Rationale behind this change modlib -> libelf is to complete prior
> changes chain, as explained by the author.
>
> If you like the change please vote +1 and it will pass. Your -1 blocks
> the change.
>
> Thanks :-)
> Tomek
>
>
>
>
> On Wed, Apr 9, 2025 at 12:56 AM Takashi Yamamoto
> <ya...@midokura.com.invalid> wrote:
> >
> > -1
> >
> > reading the recently added text in CONTRIBUTING.md,
> > this change doesn't seem even eligible for voting because
> > it is not "absolutely necessary and unavoidable".
> >
> > i personally like the change itself and prefer loosening the rules in CONTRIBUTING.md though.
> >
> >
> > On Mon, Apr 7, 2025 at 6:13 PM chao an <ma...@gmail.com> wrote:
> >>
> >> Hi community,
> >>
> >> Some green hand and individual developer who are not familiar with nuttx may be confused by the naming of modlib, in currect implement, modlib as an elf loader and parser, does not provide any features other than elf.
> >>
> >> In this pull request, I plan to rename modlib to elf, and adjust it from the architecture level as follows:
> >>
> >> https://github.com/apache/nuttx/pull/15765
> >>
> >>
> >>
> >>
> >> In addition from other popular operating systems, different loadable types are all implemented in binfmt. Therefore, it is also impossible for modlib to support formats other than ELF in the future:
> >>
> >> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> >> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> >> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> >> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> >> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> >> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
> >>
> >> This is where they belong:
> >> https://github.com/apache/nuttx/tree/master/binfmt
> >>
> >>
> >> So I need your vote here:
> >> If you prefer modlib, please reply with -1.
> >> If you recommend libelf, please reply with +1.
> >>
> >> BRs,
>
>
>
> --
> CeDeROM, SQ7MHZ, http://www.tomek.cedro.info

Re: Vote for rename modlib to libelf

Posted by Takashi Yamamoto <ya...@midokura.com.INVALID>.
On Wed, Apr 9, 2025 at 9:22 AM Tomek CEDRO <to...@cedro.info> wrote:
>
> Hi Takashi :-)
>
> There were long discussions on the mailing list, then voting, then
> discussion on the PR, and comes after lots of breaking changes being
> too freely merged into the upstream, sometimes with laconic
> description and sometimes without even testing. This is to focus more
> on long term self-compatibility and maintenance and improve overall
> pr/commit/code quality. As you can see we are testing "new process" of
> breaking changes processing.. more attention is given to breaking
> stuff.. pr/commits descriptions are better.. we have discussions on
> the mailing list prior breaking change is merged, and it is still
> possible to introduce breaking stuff, but more carefully. Please take
> a look at mailing list archives.
>
> Rationale behind this change modlib -> libelf is to complete prior
> changes chain, as explained by the author.
>
> If you like the change please vote +1 and it will pass. Your -1 blocks
> the change.

i'm not a "NuttX PMC" member and thus my vote is not a "binding vote" and
do not block the change, does it?

>
> Thanks :-)
> Tomek
>
>
>
>
> On Wed, Apr 9, 2025 at 12:56 AM Takashi Yamamoto
> <ya...@midokura.com.invalid> wrote:
> >
> > -1
> >
> > reading the recently added text in CONTRIBUTING.md,
> > this change doesn't seem even eligible for voting because
> > it is not "absolutely necessary and unavoidable".
> >
> > i personally like the change itself and prefer loosening the rules in CONTRIBUTING.md though.
> >
> >
> > On Mon, Apr 7, 2025 at 6:13 PM chao an <ma...@gmail.com> wrote:
> >>
> >> Hi community,
> >>
> >> Some green hand and individual developer who are not familiar with nuttx may be confused by the naming of modlib, in currect implement, modlib as an elf loader and parser, does not provide any features other than elf.
> >>
> >> In this pull request, I plan to rename modlib to elf, and adjust it from the architecture level as follows:
> >>
> >> https://github.com/apache/nuttx/pull/15765
> >>
> >>
> >>
> >>
> >> In addition from other popular operating systems, different loadable types are all implemented in binfmt. Therefore, it is also impossible for modlib to support formats other than ELF in the future:
> >>
> >> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> >> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> >> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> >> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> >> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> >> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
> >>
> >> This is where they belong:
> >> https://github.com/apache/nuttx/tree/master/binfmt
> >>
> >>
> >> So I need your vote here:
> >> If you prefer modlib, please reply with -1.
> >> If you recommend libelf, please reply with +1.
> >>
> >> BRs,
>
>
>
> --
> CeDeROM, SQ7MHZ, http://www.tomek.cedro.info

Re: Vote for rename modlib to libelf

Posted by Tomek CEDRO <to...@cedro.info>.
Hi Takashi :-)

There were long discussions on the mailing list, then voting, then
discussion on the PR, and comes after lots of breaking changes being
too freely merged into the upstream, sometimes with laconic
description and sometimes without even testing. This is to focus more
on long term self-compatibility and maintenance and improve overall
pr/commit/code quality. As you can see we are testing "new process" of
breaking changes processing.. more attention is given to breaking
stuff.. pr/commits descriptions are better.. we have discussions on
the mailing list prior breaking change is merged, and it is still
possible to introduce breaking stuff, but more carefully. Please take
a look at mailing list archives.

Rationale behind this change modlib -> libelf is to complete prior
changes chain, as explained by the author.

If you like the change please vote +1 and it will pass. Your -1 blocks
the change.

Thanks :-)
Tomek




On Wed, Apr 9, 2025 at 12:56 AM Takashi Yamamoto
<ya...@midokura.com.invalid> wrote:
>
> -1
>
> reading the recently added text in CONTRIBUTING.md,
> this change doesn't seem even eligible for voting because
> it is not "absolutely necessary and unavoidable".
>
> i personally like the change itself and prefer loosening the rules in CONTRIBUTING.md though.
>
>
> On Mon, Apr 7, 2025 at 6:13 PM chao an <ma...@gmail.com> wrote:
>>
>> Hi community,
>>
>> Some green hand and individual developer who are not familiar with nuttx may be confused by the naming of modlib, in currect implement, modlib as an elf loader and parser, does not provide any features other than elf.
>>
>> In this pull request, I plan to rename modlib to elf, and adjust it from the architecture level as follows:
>>
>> https://github.com/apache/nuttx/pull/15765
>>
>>
>>
>>
>> In addition from other popular operating systems, different loadable types are all implemented in binfmt. Therefore, it is also impossible for modlib to support formats other than ELF in the future:
>>
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
>> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>>
>> This is where they belong:
>> https://github.com/apache/nuttx/tree/master/binfmt
>>
>>
>> So I need your vote here:
>> If you prefer modlib, please reply with -1.
>> If you recommend libelf, please reply with +1.
>>
>> BRs,



-- 
CeDeROM, SQ7MHZ, http://www.tomek.cedro.info

Re: Vote for rename modlib to libelf

Posted by chao an <ma...@gmail.com>.
@yamamoto Thanks for your comments!

BRs,

Takashi Yamamoto <ya...@midokura.com.invalid> 于2025年4月10日周四 11:37写道:

>
>
> On Thu, Apr 10, 2025 at 11:55 AM chao an <ma...@gmail.com> wrote:
>
>> This change has no functional impact, so it does not meet the "absolutely
>> necessary and unavoidable" constraint.
>> But this commit will affect everyone's understanding of the kernel's key
>> features, which is a good thing in further. I think it meets the "necessary
>> and unavoidable" constraint.
>>
> In addition, I don't think PMC has any privileges. Anyone can vote on the
>> mailing list, and we also need the opinions of experts like you.
>>
>
> the sentence "NuttX PMC members cast binding votes" in CONTRIBUTING.md
> section 1.12 made me think otherwise.
>
> anyway, the code change itself is fine for me.
> if everyone here is happy with the interaction with the CONTRIBTING.md
> text, (it seems so) i withdraw my -1 vote.
>
>
>> BRs,
>>
>> Takashi Yamamoto <ya...@midokura.com.invalid> 于2025年4月10日周四 10:37写道:
>>
>>>
>>>
>>> On Thu, Apr 10, 2025 at 10:44 AM chao an <ma...@gmail.com> wrote:
>>>
>>>> Yamamoto san, there may be some objective factors here, but we may
>>>> already be on the way to voting. could you please vote again based on the
>>>> changes from the "code" perspective?
>>>>
>>>
>>> i've read CONTRIBUTING.md 1.12 and 1.13 a few times.
>>> but i don't see what's i'm missing.
>>> do people here think this change is "absolutely necessary and
>>> unavoidable"?
>>>
>>>
>>>>
>>>> BRs,
>>>>
>>>> Takashi Yamamoto <ya...@midokura.com.invalid> 于2025年4月9日周三 06:56写道:
>>>>
>>>>> -1
>>>>>
>>>>> reading the recently added text in CONTRIBUTING.md,
>>>>> this change doesn't seem even eligible for voting because
>>>>> it is not "absolutely necessary and unavoidable".
>>>>>
>>>>> i personally like the change itself and prefer loosening the rules in
>>>>> CONTRIBUTING.md though.
>>>>>
>>>>>
>>>>> On Mon, Apr 7, 2025 at 6:13 PM chao an <ma...@gmail.com> wrote:
>>>>>
>>>>>> Hi community,
>>>>>>
>>>>>> Some green hand and individual developer who are not familiar with
>>>>>> nuttx may be confused by the naming of modlib, in currect implement, modlib
>>>>>> as an elf loader and parser, does not provide any features other than elf.
>>>>>>
>>>>>> In this pull request, I plan to rename modlib to elf, and adjust it
>>>>>> from the architecture level as follows:
>>>>>>
>>>>>> https://github.com/apache/nuttx/pull/15765
>>>>>>
>>>>>>
>>>>>> [image: image.png]
>>>>>>
>>>>>> In addition from other popular operating systems, different loadable
>>>>>> types are all implemented in binfmt. Therefore, it is also impossible for
>>>>>> modlib to support formats other than ELF in the future:
>>>>>>
>>>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
>>>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
>>>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
>>>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
>>>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
>>>>>>
>>>>>> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>>>>>>
>>>>>> This is where they belong:
>>>>>> https://github.com/apache/nuttx/tree/master/binfmt
>>>>>>
>>>>>>
>>>>>> So I need your vote here:
>>>>>> If you prefer modlib, please reply with -1.
>>>>>> If you recommend libelf, please reply with +1.
>>>>>>
>>>>>> BRs,
>>>>>>
>>>>>

Re: Vote for rename modlib to libelf

Posted by Takashi Yamamoto <ya...@midokura.com.INVALID>.
On Thu, Apr 10, 2025 at 11:55 AM chao an <ma...@gmail.com> wrote:

> This change has no functional impact, so it does not meet the "absolutely
> necessary and unavoidable" constraint.
> But this commit will affect everyone's understanding of the kernel's key
> features, which is a good thing in further. I think it meets the "necessary
> and unavoidable" constraint.
>
In addition, I don't think PMC has any privileges. Anyone can vote on the
> mailing list, and we also need the opinions of experts like you.
>

the sentence "NuttX PMC members cast binding votes" in CONTRIBUTING.md
section 1.12 made me think otherwise.

anyway, the code change itself is fine for me.
if everyone here is happy with the interaction with the CONTRIBTING.md
text, (it seems so) i withdraw my -1 vote.


> BRs,
>
> Takashi Yamamoto <ya...@midokura.com.invalid> 于2025年4月10日周四 10:37写道:
>
>>
>>
>> On Thu, Apr 10, 2025 at 10:44 AM chao an <ma...@gmail.com> wrote:
>>
>>> Yamamoto san, there may be some objective factors here, but we may
>>> already be on the way to voting. could you please vote again based on the
>>> changes from the "code" perspective?
>>>
>>
>> i've read CONTRIBUTING.md 1.12 and 1.13 a few times.
>> but i don't see what's i'm missing.
>> do people here think this change is "absolutely necessary and
>> unavoidable"?
>>
>>
>>>
>>> BRs,
>>>
>>> Takashi Yamamoto <ya...@midokura.com.invalid> 于2025年4月9日周三 06:56写道:
>>>
>>>> -1
>>>>
>>>> reading the recently added text in CONTRIBUTING.md,
>>>> this change doesn't seem even eligible for voting because
>>>> it is not "absolutely necessary and unavoidable".
>>>>
>>>> i personally like the change itself and prefer loosening the rules in
>>>> CONTRIBUTING.md though.
>>>>
>>>>
>>>> On Mon, Apr 7, 2025 at 6:13 PM chao an <ma...@gmail.com> wrote:
>>>>
>>>>> Hi community,
>>>>>
>>>>> Some green hand and individual developer who are not familiar with
>>>>> nuttx may be confused by the naming of modlib, in currect implement, modlib
>>>>> as an elf loader and parser, does not provide any features other than elf.
>>>>>
>>>>> In this pull request, I plan to rename modlib to elf, and adjust it
>>>>> from the architecture level as follows:
>>>>>
>>>>> https://github.com/apache/nuttx/pull/15765
>>>>>
>>>>>
>>>>> [image: image.png]
>>>>>
>>>>> In addition from other popular operating systems, different loadable
>>>>> types are all implemented in binfmt. Therefore, it is also impossible for
>>>>> modlib to support formats other than ELF in the future:
>>>>>
>>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
>>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
>>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
>>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
>>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
>>>>>
>>>>> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>>>>>
>>>>> This is where they belong:
>>>>> https://github.com/apache/nuttx/tree/master/binfmt
>>>>>
>>>>>
>>>>> So I need your vote here:
>>>>> If you prefer modlib, please reply with -1.
>>>>> If you recommend libelf, please reply with +1.
>>>>>
>>>>> BRs,
>>>>>
>>>>

Re: Vote for rename modlib to libelf

Posted by chao an <ma...@gmail.com>.
This change has no functional impact, so it does not meet the "absolutely
necessary and unavoidable" constraint.
But this commit will affect everyone's understanding of the kernel's key
features, which is a good thing in further. I think it meets the "necessary
and unavoidable" constraint.
In addition, I don't think PMC has any privileges. Anyone can vote on the
mailing list, and we also need the opinions of experts like you.

BRs,

Takashi Yamamoto <ya...@midokura.com.invalid> 于2025年4月10日周四 10:37写道:

>
>
> On Thu, Apr 10, 2025 at 10:44 AM chao an <ma...@gmail.com> wrote:
>
>> Yamamoto san, there may be some objective factors here, but we may
>> already be on the way to voting. could you please vote again based on the
>> changes from the "code" perspective?
>>
>
> i've read CONTRIBUTING.md 1.12 and 1.13 a few times.
> but i don't see what's i'm missing.
> do people here think this change is "absolutely necessary and unavoidable"?
>
>
>>
>> BRs,
>>
>> Takashi Yamamoto <ya...@midokura.com.invalid> 于2025年4月9日周三 06:56写道:
>>
>>> -1
>>>
>>> reading the recently added text in CONTRIBUTING.md,
>>> this change doesn't seem even eligible for voting because
>>> it is not "absolutely necessary and unavoidable".
>>>
>>> i personally like the change itself and prefer loosening the rules in
>>> CONTRIBUTING.md though.
>>>
>>>
>>> On Mon, Apr 7, 2025 at 6:13 PM chao an <ma...@gmail.com> wrote:
>>>
>>>> Hi community,
>>>>
>>>> Some green hand and individual developer who are not familiar with
>>>> nuttx may be confused by the naming of modlib, in currect implement, modlib
>>>> as an elf loader and parser, does not provide any features other than elf.
>>>>
>>>> In this pull request, I plan to rename modlib to elf, and adjust it
>>>> from the architecture level as follows:
>>>>
>>>> https://github.com/apache/nuttx/pull/15765
>>>>
>>>>
>>>> [image: image.png]
>>>>
>>>> In addition from other popular operating systems, different loadable
>>>> types are all implemented in binfmt. Therefore, it is also impossible for
>>>> modlib to support formats other than ELF in the future:
>>>>
>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
>>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
>>>>
>>>> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>>>>
>>>> This is where they belong:
>>>> https://github.com/apache/nuttx/tree/master/binfmt
>>>>
>>>>
>>>> So I need your vote here:
>>>> If you prefer modlib, please reply with -1.
>>>> If you recommend libelf, please reply with +1.
>>>>
>>>> BRs,
>>>>
>>>

Re: Vote for rename modlib to libelf

Posted by Takashi Yamamoto <ya...@midokura.com.INVALID>.
On Thu, Apr 10, 2025 at 10:44 AM chao an <ma...@gmail.com> wrote:

> Yamamoto san, there may be some objective factors here, but we may already
> be on the way to voting. could you please vote again based on the changes
> from the "code" perspective?
>

i've read CONTRIBUTING.md 1.12 and 1.13 a few times.
but i don't see what's i'm missing.
do people here think this change is "absolutely necessary and unavoidable"?


>
> BRs,
>
> Takashi Yamamoto <ya...@midokura.com.invalid> 于2025年4月9日周三 06:56写道:
>
>> -1
>>
>> reading the recently added text in CONTRIBUTING.md,
>> this change doesn't seem even eligible for voting because
>> it is not "absolutely necessary and unavoidable".
>>
>> i personally like the change itself and prefer loosening the rules in
>> CONTRIBUTING.md though.
>>
>>
>> On Mon, Apr 7, 2025 at 6:13 PM chao an <ma...@gmail.com> wrote:
>>
>>> Hi community,
>>>
>>> Some green hand and individual developer who are not familiar with nuttx
>>> may be confused by the naming of modlib, in currect implement, modlib as an
>>> elf loader and parser, does not provide any features other than elf.
>>>
>>> In this pull request, I plan to rename modlib to elf, and adjust it from
>>> the architecture level as follows:
>>>
>>> https://github.com/apache/nuttx/pull/15765
>>>
>>>
>>> [image: image.png]
>>>
>>> In addition from other popular operating systems, different loadable
>>> types are all implemented in binfmt. Therefore, it is also impossible for
>>> modlib to support formats other than ELF in the future:
>>>
>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
>>>
>>> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>>>
>>> This is where they belong:
>>> https://github.com/apache/nuttx/tree/master/binfmt
>>>
>>>
>>> So I need your vote here:
>>> If you prefer modlib, please reply with -1.
>>> If you recommend libelf, please reply with +1.
>>>
>>> BRs,
>>>
>>

Re: Vote for rename modlib to libelf

Posted by chao an <ma...@gmail.com>.
Yamamoto san, there may be some objective factors here, but we may already
be on the way to voting. could you please vote again based on the changes
from the "code" perspective?

BRs,

Takashi Yamamoto <ya...@midokura.com.invalid> 于2025年4月9日周三 06:56写道:

> -1
>
> reading the recently added text in CONTRIBUTING.md,
> this change doesn't seem even eligible for voting because
> it is not "absolutely necessary and unavoidable".
>
> i personally like the change itself and prefer loosening the rules in
> CONTRIBUTING.md though.
>
>
> On Mon, Apr 7, 2025 at 6:13 PM chao an <ma...@gmail.com> wrote:
>
>> Hi community,
>>
>> Some green hand and individual developer who are not familiar with nuttx
>> may be confused by the naming of modlib, in currect implement, modlib as an
>> elf loader and parser, does not provide any features other than elf.
>>
>> In this pull request, I plan to rename modlib to elf, and adjust it from
>> the architecture level as follows:
>>
>> https://github.com/apache/nuttx/pull/15765
>>
>>
>> [image: image.png]
>>
>> In addition from other popular operating systems, different loadable
>> types are all implemented in binfmt. Therefore, it is also impossible for
>> modlib to support formats other than ELF in the future:
>>
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
>>
>> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>>
>> This is where they belong:
>> https://github.com/apache/nuttx/tree/master/binfmt
>>
>>
>> So I need your vote here:
>> If you prefer modlib, please reply with -1.
>> If you recommend libelf, please reply with +1.
>>
>> BRs,
>>
>

Re: Vote for rename modlib to libelf

Posted by Takashi Yamamoto <ya...@midokura.com.INVALID>.
-1

reading the recently added text in CONTRIBUTING.md,
this change doesn't seem even eligible for voting because
it is not "absolutely necessary and unavoidable".

i personally like the change itself and prefer loosening the rules in
CONTRIBUTING.md though.


On Mon, Apr 7, 2025 at 6:13 PM chao an <ma...@gmail.com> wrote:

> Hi community,
>
> Some green hand and individual developer who are not familiar with nuttx
> may be confused by the naming of modlib, in currect implement, modlib as an
> elf loader and parser, does not provide any features other than elf.
>
> In this pull request, I plan to rename modlib to elf, and adjust it from
> the architecture level as follows:
>
> https://github.com/apache/nuttx/pull/15765
>
>
> [image: image.png]
>
> In addition from other popular operating systems, different loadable types
> are all implemented in binfmt. Therefore, it is also impossible for modlib
> to support formats other than ELF in the future:
>
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>
> This is where they belong:
> https://github.com/apache/nuttx/tree/master/binfmt
>
>
> So I need your vote here:
> If you prefer modlib, please reply with -1.
> If you recommend libelf, please reply with +1.
>
> BRs,
>

Re: Vote for rename modlib to libelf

Posted by raiden00pl <ra...@gmail.com>.
+1

pon., 7 kwi 2025 o 16:12 Alan C. Assis <ac...@gmail.com> napisał(a):

> +1
>
> On Mon, Apr 7, 2025 at 6:13 AM chao an <ma...@gmail.com> wrote:
>
>> Hi community,
>>
>> Some green hand and individual developer who are not familiar with nuttx
>> may be confused by the naming of modlib, in currect implement, modlib as an
>> elf loader and parser, does not provide any features other than elf.
>>
>> In this pull request, I plan to rename modlib to elf, and adjust it from
>> the architecture level as follows:
>>
>> https://github.com/apache/nuttx/pull/15765
>>
>>
>> [image: image.png]
>>
>> In addition from other popular operating systems, different loadable
>> types are all implemented in binfmt. Therefore, it is also impossible for
>> modlib to support formats other than ELF in the future:
>>
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
>>
>> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>>
>> This is where they belong:
>> https://github.com/apache/nuttx/tree/master/binfmt
>>
>>
>> So I need your vote here:
>> If you prefer modlib, please reply with -1.
>> If you recommend libelf, please reply with +1.
>>
>> BRs,
>>
>

Re: Vote for rename modlib to libelf

Posted by "Alan C. Assis" <ac...@gmail.com>.
+1

On Mon, Apr 7, 2025 at 6:13 AM chao an <ma...@gmail.com> wrote:

> Hi community,
>
> Some green hand and individual developer who are not familiar with nuttx
> may be confused by the naming of modlib, in currect implement, modlib as an
> elf loader and parser, does not provide any features other than elf.
>
> In this pull request, I plan to rename modlib to elf, and adjust it from
> the architecture level as follows:
>
> https://github.com/apache/nuttx/pull/15765
>
>
> [image: image.png]
>
> In addition from other popular operating systems, different loadable types
> are all implemented in binfmt. Therefore, it is also impossible for modlib
> to support formats other than ELF in the future:
>
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>
> This is where they belong:
> https://github.com/apache/nuttx/tree/master/binfmt
>
>
> So I need your vote here:
> If you prefer modlib, please reply with -1.
> If you recommend libelf, please reply with +1.
>
> BRs,
>

Re: Vote for rename modlib to libelf

Posted by Alin Jerpelea <je...@gmail.com>.
+1

On Mon, 7 Apr 2025, 17:28 Maciej Wójcik, <w8...@gmail.com> wrote:

> +1
>
> Am Mo., 7. Apr. 2025 um 16:49 Uhr schrieb Laczen JMS <laczenjms@gmail.com
> >:
>
>> +1
>>
>> On Mon, Apr 7, 2025, 11:36 chao an <ma...@gmail.com> wrote:
>>
>>> Hi community,
>>>
>>> Some green hand and individual developer who are not familiar with nuttx
>>> may be confused by the naming of modlib, in currect implement, modlib as an
>>> elf loader and parser, does not provide any features other than elf.
>>>
>>> In this pull request, I plan to rename modlib to elf, and adjust it from
>>> the architecture level as follows:
>>>
>>> https://github.com/apache/nuttx/pull/15765
>>>
>>>
>>> [image: image.png]
>>>
>>> In addition from other popular operating systems, different loadable
>>> types are all implemented in binfmt. Therefore, it is also impossible for
>>> modlib to support formats other than ELF in the future:
>>>
>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
>>>
>>> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>>>
>>> This is where they belong:
>>> https://github.com/apache/nuttx/tree/master/binfmt
>>>
>>>
>>> So I need your vote here:
>>> If you prefer modlib, please reply with -1.
>>> If you recommend libelf, please reply with +1.
>>>
>>> BRs,
>>>
>>

Re: Vote for rename modlib to libelf

Posted by Maciej Wójcik <w8...@gmail.com>.
+1

Am Mo., 7. Apr. 2025 um 16:49 Uhr schrieb Laczen JMS <la...@gmail.com>:

> +1
>
> On Mon, Apr 7, 2025, 11:36 chao an <ma...@gmail.com> wrote:
>
>> Hi community,
>>
>> Some green hand and individual developer who are not familiar with nuttx
>> may be confused by the naming of modlib, in currect implement, modlib as an
>> elf loader and parser, does not provide any features other than elf.
>>
>> In this pull request, I plan to rename modlib to elf, and adjust it from
>> the architecture level as follows:
>>
>> https://github.com/apache/nuttx/pull/15765
>>
>>
>> [image: image.png]
>>
>> In addition from other popular operating systems, different loadable
>> types are all implemented in binfmt. Therefore, it is also impossible for
>> modlib to support formats other than ELF in the future:
>>
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
>> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
>>
>> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>>
>> This is where they belong:
>> https://github.com/apache/nuttx/tree/master/binfmt
>>
>>
>> So I need your vote here:
>> If you prefer modlib, please reply with -1.
>> If you recommend libelf, please reply with +1.
>>
>> BRs,
>>
>

Re: Vote for rename modlib to libelf

Posted by Laczen JMS <la...@gmail.com>.
+1

On Mon, Apr 7, 2025, 11:36 chao an <ma...@gmail.com> wrote:

> Hi community,
>
> Some green hand and individual developer who are not familiar with nuttx
> may be confused by the naming of modlib, in currect implement, modlib as an
> elf loader and parser, does not provide any features other than elf.
>
> In this pull request, I plan to rename modlib to elf, and adjust it from
> the architecture level as follows:
>
> https://github.com/apache/nuttx/pull/15765
>
>
> [image: image.png]
>
> In addition from other popular operating systems, different loadable types
> are all implemented in binfmt. Therefore, it is also impossible for modlib
> to support formats other than ELF in the future:
>
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
>
> This is where they belong:
> https://github.com/apache/nuttx/tree/master/binfmt
>
>
> So I need your vote here:
> If you prefer modlib, please reply with -1.
> If you recommend libelf, please reply with +1.
>
> BRs,
>