You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zhouyifan279 (via GitHub)" <gi...@apache.org> on 2023/08/28 14:10:52 UTC
[GitHub] [incubator-celeborn] zhouyifan279 opened a new pull request, #1850: [CELEBORN-912] Support build with Spark 3.5
zhouyifan279 opened a new pull request, #1850:
URL: https://github.com/apache/incubator-celeborn/pull/1850
### What changes were proposed in this pull request?
Support build with Spark 3.5
### Why are the changes needed?
Keep up with upstream.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Build with `mvn` and `sbt` locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1850: [CELEBORN-912] Support build with Spark 3.5
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1850:
URL: https://github.com/apache/incubator-celeborn/pull/1850#issuecomment-1696705828
Thanks, merging to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cfmcgrady commented on a diff in pull request #1850: [CELEBORN-912] Support build with Spark 3.5
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #1850:
URL: https://github.com/apache/incubator-celeborn/pull/1850#discussion_r1307704165
##########
pom.xml:
##########
@@ -991,6 +996,27 @@
</properties>
</profile>
+ <profile>
+ <id>spark-3.5</id>
+ <modules>
+ <module>client-spark/common</module>
+ <module>client-spark/spark-3</module>
+ <!-- TODO solve compilation error when build spark-3-columnar-shuffle with Spark 3.5 -->
+ <!-- <module>client-spark/spark-3-columnar-shuffle</module> -->
+ <module>client-spark/spark-3-shaded</module>
+ <module>tests/spark-it</module>
+ </modules>
+ <properties>
+ <jackson.version>2.15.2</jackson.version>
+ <jackson.databind.version>2.15.2</jackson.databind.version>
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1850: [CELEBORN-912] Support build with Spark 3.5
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1850: [CELEBORN-912] Support build with Spark 3.5
URL: https://github.com/apache/incubator-celeborn/pull/1850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1850: [CELEBORN-912] Support build with Spark 3.5
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1850:
URL: https://github.com/apache/incubator-celeborn/pull/1850#issuecomment-1695790197
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1850?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1850](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1850?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (659f2d9) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/2c07c55e7781e8c0f551ee669d007b33c856cadb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2c07c55) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 659f2d9 differs from pull request most recent head 6921970. Consider uploading reports for the commit 6921970 to get more accurate results
```diff
@@ Coverage Diff @@
## main #1850 +/- ##
==========================================
- Coverage 46.70% 46.54% -0.15%
==========================================
Files 163 163
Lines 10153 10153
Branches 934 934
==========================================
- Hits 4741 4725 -16
- Misses 5103 5116 +13
- Partials 309 312 +3
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1850/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zhouyifan279 commented on a diff in pull request #1850: [CELEBORN-912] Support build with Spark 3.5
Posted by "zhouyifan279 (via GitHub)" <gi...@apache.org>.
zhouyifan279 commented on code in PR #1850:
URL: https://github.com/apache/incubator-celeborn/pull/1850#discussion_r1308110276
##########
pom.xml:
##########
@@ -991,6 +996,27 @@
</properties>
</profile>
+ <profile>
+ <id>spark-3.5</id>
+ <modules>
+ <module>client-spark/common</module>
+ <module>client-spark/spark-3</module>
+ <!-- TODO solve compilation error when build spark-3-columnar-shuffle with Spark 3.5 -->
+ <!-- <module>client-spark/spark-3-columnar-shuffle</module> -->
+ <module>client-spark/spark-3-shaded</module>
+ <module>tests/spark-it</module>
+ </modules>
+ <properties>
+ <jackson.version>2.15.2</jackson.version>
+ <jackson.databind.version>2.15.2</jackson.databind.version>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org