You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/04 14:18:15 UTC
[GitHub] [incubator-devlake] mintsweet opened a new pull request, #4106: fix(config-ui): some bugs
mintsweet opened a new pull request, #4106:
URL: https://github.com/apache/incubator-devlake/pull/4106
### Summary
1. use **data entities** label to replace value.
2. adjust the **transformation** wording.
3. adjust the style for **bp save button**.
4. adjust the style for **rerun icon**.
5. unify the type of **scopeId**.
6. adjust the scopeIds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4106: fix(config-ui): some bugs
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #4106:
URL: https://github.com/apache/incubator-devlake/pull/4106#discussion_r1061536236
##########
config-ui/src/pages/blueprint/create/step-three/index.tsx:
##########
@@ -52,10 +52,7 @@ export const StepThree = () => {
const scope = scopeMap[unique] ?? [];
return {
...connection,
- scope: scope.map((sc: any) => ({
- id: `${sc.id}`,
- entities: `${sc.entities}`,
- })),
+ scopeIds: scope.map((sc: any) => sc.id),
Review Comment:
I think it kind of confuse to use a scope as a Array. Just use scopes and forget glasses..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4106: fix(config-ui): some bugs
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #4106:
URL: https://github.com/apache/incubator-devlake/pull/4106#discussion_r1061532632
##########
config-ui/src/error/components/bp-upgrade/use-bp-upgrade.ts:
##########
@@ -118,11 +118,12 @@ export const useBPUpgrade = ({ id, onResetError }: UseBPUpgradeProps) => {
const upgradeConnection = async (connection: any) => {
const { plugin, connectionId } = connection;
- const scopeList = await Promise.all((connection.scope ?? []).map((sc: any) => upgradeScope(plugin, connectionId, sc)));
+ const scope = await Promise.all((connection.scope ?? []).map((sc: any) => upgradeScope(plugin, connectionId, sc)));
Review Comment:
Emmm..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh merged pull request #4106: fix(config-ui): some bugs
Posted by GitBox <gi...@apache.org>.
likyh merged PR #4106:
URL: https://github.com/apache/incubator-devlake/pull/4106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org