You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by cs...@apache.org on 2023/11/10 12:40:23 UTC

(maven-resolver) branch master updated: [MRESOLVER-431] Make chained repository and transfer listeners extensible (#361)

This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git


The following commit(s) were added to refs/heads/master by this push:
     new 4d396269 [MRESOLVER-431] Make chained repository and transfer listeners extensible (#361)
4d396269 is described below

commit 4d396269763728081c779a0fd1dcd76a0a9b8a28
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Fri Nov 10 13:40:18 2023 +0100

    [MRESOLVER-431] Make chained repository and transfer listeners extensible (#361)
    
    Add ability to extend classes.
    
    ---
    
    https://issues.apache.org/jira/browse/MRESOLVER-431
---
 .../org/eclipse/aether/util/listener/ChainedRepositoryListener.java  | 5 ++++-
 .../org/eclipse/aether/util/listener/ChainedTransferListener.java    | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/maven-resolver-util/src/main/java/org/eclipse/aether/util/listener/ChainedRepositoryListener.java b/maven-resolver-util/src/main/java/org/eclipse/aether/util/listener/ChainedRepositoryListener.java
index e263129d..4b9e8f6a 100644
--- a/maven-resolver-util/src/main/java/org/eclipse/aether/util/listener/ChainedRepositoryListener.java
+++ b/maven-resolver-util/src/main/java/org/eclipse/aether/util/listener/ChainedRepositoryListener.java
@@ -33,7 +33,7 @@ import static java.util.Objects.requireNonNull;
  * A repository listener that delegates to zero or more other listeners (multicast). The list of target listeners is
  * thread-safe, i.e. target listeners can be added or removed by any thread at any time.
  */
-public final class ChainedRepositoryListener extends AbstractRepositoryListener {
+public class ChainedRepositoryListener extends AbstractRepositoryListener {
 
     private final List<RepositoryListener> listeners = new CopyOnWriteArrayList<>();
 
@@ -110,6 +110,9 @@ public final class ChainedRepositoryListener extends AbstractRepositoryListener
         }
     }
 
+    /**
+     * Invoked when any listener throws, by default is no op, extend if required.
+     */
     @SuppressWarnings("EmptyMethod")
     protected void handleError(RepositoryEvent event, RepositoryListener listener, RuntimeException error) {
         // default just swallows errors
diff --git a/maven-resolver-util/src/main/java/org/eclipse/aether/util/listener/ChainedTransferListener.java b/maven-resolver-util/src/main/java/org/eclipse/aether/util/listener/ChainedTransferListener.java
index 2c21d10e..ea87306c 100644
--- a/maven-resolver-util/src/main/java/org/eclipse/aether/util/listener/ChainedTransferListener.java
+++ b/maven-resolver-util/src/main/java/org/eclipse/aether/util/listener/ChainedTransferListener.java
@@ -34,7 +34,7 @@ import static java.util.Objects.requireNonNull;
  * A transfer listener that delegates to zero or more other listeners (multicast). The list of target listeners is
  * thread-safe, i.e. target listeners can be added or removed by any thread at any time.
  */
-public final class ChainedTransferListener extends AbstractTransferListener {
+public class ChainedTransferListener extends AbstractTransferListener {
 
     private final List<TransferListener> listeners = new CopyOnWriteArrayList<>();
 
@@ -111,6 +111,9 @@ public final class ChainedTransferListener extends AbstractTransferListener {
         }
     }
 
+    /**
+     * Invoked when any listener throws, by default is no op, extend if required.
+     */
     @SuppressWarnings("EmptyMethod")
     protected void handleError(TransferEvent event, TransferListener listener, RuntimeException error) {
         // default just swallows errors