[GitHub] [jmeter] FSchumacher opened a new pull request, #5736: Allow SampleResult#setEndTime be set in JSR223Sampler

[GitBox <gi...@apache.org>]

FSchumacher opened a new pull request, #5736:
URL: https://github.com/apache/jmeter/pull/5736

   Issue #5733
   
   ## Description
   JSR223Sampler throws an exception, when the sampler has set the endTime of the sampleResult. 
   
   ## Motivation and Context
   JSR223Sampler is often used to create results in a freestyle mode. So setting the endTime of a SampleResult should be allowed.
   
   ## How Has This Been Tested?
   Added a new Test class, that tests both paths setting and not setting the endTime on the SampleResult.
   
   ## Screenshots (if appropriate):
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Delete as appropriate -->
   - Bug fix (non-breaking change which fixes an issue)
   - New feature (non-breaking change which adds functionality)
   - Breaking change (fix or feature that would cause existing functionality to not work as expected)
   
   It is a bit hard to decide on this. I think of it as a bug fix.
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] asfgit closed pull request #5736: Allow SampleResult#setEndTime be set in JSR223Sampler

[GitBox <gi...@apache.org>]

asfgit closed pull request #5736: Allow SampleResult#setEndTime be set in JSR223Sampler
URL: https://github.com/apache/jmeter/pull/5736


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org