You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/06/24 16:53:10 UTC

Review Request 35829: BE-issue with auto-update of HDP.repo with default baseurl

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35829/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-12122.patch
    https://issues.apache.org/jira/browse/AMBARI-12122.patch


Repository: ambari


Description
-------

Install cluster with some services (2.0)
Update redhat6 HDP url to "qwerty" (validation skipped)
Check http://ambari:8080/api/v1/clusters/tdk/stack_versions/1/repository_versions/1/operating_systems/redhat6/repositories/HDP-2.2 (it contains "qwerty" as base_url)
Check HDP.repo (it contains default url)
Change HDP.repo manually (set baseurl=qwerty)
Go to ASW
Proceed to Review-step
Click Next
After some component started to install, HDP.repo file is updated with default baseurl and install completed successfully.
UI doesn't send any request to change repo-urls on ASW
This issue is already fixed in trunk


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 422ecb6 

Diff: https://reviews.apache.org/r/35829/diff/


Testing
-------

Test failures are unrelated 


Failed tests:   testRecalculateClusterVersionState(org.apache.ambari.server.state.cluster.ClusterTest): expected:<INSTALLING> but was:<OUT_OF_SYNC>
  testRecalculateAllClusterVersionStates(org.apache.ambari.server.state.cluster.ClusterTest): expected:<INSTALLING> but was:<OUT_OF_SYNC>

Tests in error: 
  testDeadlockWhileRestartingComponents(org.apache.ambari.server.state.cluster.ClusterDeadlockTest): test timed out after 60000 milliseconds

Tests run: 2793, Failures: 2, Errors: 1, Skipped: 15

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [4.907s]
[INFO] Ambari Metrics Common ............................. SUCCESS [2.240s]
[INFO] Ambari Server ..................................... FAILURE [39:23.786s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 39:31.668s
[INFO] Finished at: Wed Jun 24 17:10:16 EEST 2015
[INFO] Final Memory: 33M/272M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 35829: BE-issue with auto-update of HDP.repo with default baseurl

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35829/#review89165
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Червень 24, 2015, 2:53 після полудня, Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35829/
> -----------------------------------------------------------
> 
> (Updated Червень 24, 2015, 2:53 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-12122.patch
>     https://issues.apache.org/jira/browse/AMBARI-12122.patch
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Install cluster with some services (2.0)
> Update redhat6 HDP url to "qwerty" (validation skipped)
> Check http://ambari:8080/api/v1/clusters/tdk/stack_versions/1/repository_versions/1/operating_systems/redhat6/repositories/HDP-2.2 (it contains "qwerty" as base_url)
> Check HDP.repo (it contains default url)
> Change HDP.repo manually (set baseurl=qwerty)
> Go to ASW
> Proceed to Review-step
> Click Next
> After some component started to install, HDP.repo file is updated with default baseurl and install completed successfully.
> UI doesn't send any request to change repo-urls on ASW
> This issue is already fixed in trunk
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 422ecb6 
> 
> Diff: https://reviews.apache.org/r/35829/diff/
> 
> 
> Testing
> -------
> 
> Test failures are unrelated 
> 
> 
> Failed tests:   testRecalculateClusterVersionState(org.apache.ambari.server.state.cluster.ClusterTest): expected:<INSTALLING> but was:<OUT_OF_SYNC>
>   testRecalculateAllClusterVersionStates(org.apache.ambari.server.state.cluster.ClusterTest): expected:<INSTALLING> but was:<OUT_OF_SYNC>
> 
> Tests in error: 
>   testDeadlockWhileRestartingComponents(org.apache.ambari.server.state.cluster.ClusterDeadlockTest): test timed out after 60000 milliseconds
> 
> Tests run: 2793, Failures: 2, Errors: 1, Skipped: 15
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [4.907s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [2.240s]
> [INFO] Ambari Server ..................................... FAILURE [39:23.786s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 39:31.668s
> [INFO] Finished at: Wed Jun 24 17:10:16 EEST 2015
> [INFO] Final Memory: 33M/272M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>