You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/09/26 00:47:44 UTC
[GitHub] zeppelin pull request #3189: [ZEPPELIN-3758]. Convert old note file note.jso...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3189
[ZEPPELIN-3758]. Convert old note file note.json to new style
### What is this PR for?
This PR is follow up of ZEPPELIN-261, it is to convert old note file note.json to new style when user upgrading zeppelin before 0.9. 2 properties are introduced.
* `zeppelin.notebook.new_format.convert`, by default it is false. When enabled, zeppelin will first find all the old note file note.json and then convert it into new style.
* `zeppelin.notebook.new_format.delete_old`, by default it is false, when setting true, zeppelin will delete the old note file after converting it into new style.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3758
### How should this be tested?
* CI pass
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3758
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3189
----
commit 1f3a39888adb9f1ce722e8304ce7e757893e37b0
Author: Jeff Zhang <zj...@...>
Date: 2018-09-25T08:59:10Z
[ZEPPELIN-3758]. Convert old note file note.json to new style
----
---
[GitHub] zeppelin issue #3189: [ZEPPELIN-3758]. Convert old note file note.json to ne...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3189
Good idea, I can do it in a follow up PR.
---
[GitHub] zeppelin issue #3189: [ZEPPELIN-3758]. Convert old note file note.json to ne...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3189
Also, since we are doing this; should there be a command line utility as well? which on run from command-line can convert from old to new format.
---
[GitHub] zeppelin issue #3189: [ZEPPELIN-3758]. Convert old note file note.json to ne...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3189
Many classes are old existing code which I just rename them. e.g. `OldAzureNotebookRepo` is renamed from the old version of `AzureNotebookRepo`
---
[GitHub] zeppelin pull request #3189: [ZEPPELIN-3758]. Convert old note file note.jso...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3189
---