You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Dick Marinus <di...@etos.nl> on 2008/06/18 08:13:32 UTC
[PATCH] Issue #3189 Make CC (Carbon Copy) possible with
commit-email.pl
[[[
Fix issue #3189: Make CC (Carbon Copy) possible with commit-email.pl
* contrib/hook-scripts/commit-email.pl.in
Add -c parameter which can be repeated to specify multiple CC
addresses
]]]
Hi,
I've created a patch for commit-email.pl (issue 3189). Please review.
TIA
Dick
Re: [PATCH] Issue #3189 Make CC (Carbon Copy) possible with
commit-email.pl
Posted by Daniel Shahaf <d....@daniel.shahaf.co.il>.
Dick Marinus wrote on Wed, 18 Jun 2008 at 10:13 +0200:
> [[[
> Fix issue #3189: Make CC (Carbon Copy) possible with commit-email.pl
>
> * contrib/hook-scripts/commit-email.pl.in
> Add -c parameter which can be repeated to specify multiple CC
> addresses
> ]]]
>
It's not a review, but please notice r31755:
Author: blair
Date: Mon Jun 16 07:47:22 2008
New Revision: 31755
Log:
Deprecate commit-email.pl and recommend mailer.py. See
http://svn.haxx.se/dev/archive-2008-06/0479.shtml
* contrib/hook-scripts/commit-email.pl.in:
Renamed from tools/hook-scripts/commit-email.pl.in.
Add a comment at the top indicating this script is deprecated.
--- trunk/tools/hook-scripts/commit-email.pl.in Sun Jun 15 17:44:40 2008 (r31754, copy source)
+++ trunk/contrib/hook-scripts/commit-email.pl.in Mon Jun 16 07:47:22 2008 (r31755)
@@ -1,6 +1,14 @@
#!/usr/bin/env perl
# ====================================================================
+# This script is deprecated. The Subversion developers recommend
+# using mailer.py for post-commit and post-revprop change
+# notifications. If you wish to improve or add features to a
+# post-commit notification script, please do that work on mailer.py.
+# See http://svn.collab.net/repos/svn/trunk/tools/hook-scripts/mailer .
+# ====================================================================
+
+# ====================================================================
# commit-email.pl: send a notification email describing either a
# commit or a revprop-change action on a Subversion repository.
#
So, thanks for your patch, but it is unlikely to get reviewed as most
developers agreed that commit-email.pl should be deprecated.
You're welcome, however, to port the patch to mailer.py (if it doesn't
already have this feature) and resubmit it.
Thanks,
Daniel
> Hi,
>
> I've created a patch for commit-email.pl (issue 3189). Please review.
>
> TIA
> Dick
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org