You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/19 14:07:00 UTC
[jira] [Commented] (AIRFLOW-5462) Google Authentication redirection
page crashes with KeyError: 'login'
[ https://issues.apache.org/jira/browse/AIRFLOW-5462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977517#comment-16977517 ]
ASF GitHub Bot commented on AIRFLOW-5462:
-----------------------------------------
paulvic commented on pull request #6607: [AIRFLOW-5462] Bump FAB to 2.2.0 to fix OAuth login issue
URL: https://github.com/apache/airflow/pull/6607
Same fix as was required for Superset (https://github.com/apache/incubator-superset/issues/7739)
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5462
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
When using OAuth for authentication, if the `next` request parameter isn't set in the URL then the initial redirect is broken after logging in. This was fixed in FAB (https://github.com/dpgaspar/Flask-AppBuilder/pull/1095) and so the version of FAB needs to be bumped to pick up the fix.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
I'm not sure if we would add tests for an external package.
I have tested this manually and confirmed the issue is resolved.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Google Authentication redirection page crashes with KeyError: 'login'
> ---------------------------------------------------------------------
>
> Key: AIRFLOW-5462
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5462
> Project: Apache Airflow
> Issue Type: Bug
> Components: authentication
> Affects Versions: 1.10.3, 1.10.4, 1.10.5
> Reporter: Qian Yu
> Priority: Minor
>
> When user is logged out and try to access the URL of a DAG's TreeView, he's redirected to login page. However, after he logs in with google authentication, the page redirects to the oauth-authorized/login page and crashes with a mushroom cloud.
>
> Expected:
> Redirects back to the original URL the user wanted to access
> Actual:
> Crash with mushroom cloud
>
> Configuration:
> {code:python}
> [webserver]
> authenticate = True
> auth_backend = airflow.contrib.auth.backends.google_auth
> [google]
> client_id = google_client_id
> client_secret = google_client_secret
> oauth_callback_route = /oauth2callback
> domain = "example1.com,example2.com"
> {code}
>
> The issue looks similar to the one described here: [https://github.com/apache/incubator-superset/issues/7739]
> {code:python}
> ____/ ( ( ) ) \___
> /( ( ( ) _ )) ) )\
> (( ( )( ) ) ( ) )
> ((/ ( _( ) ( _) ) ( () ) )
> ( ( ( (_) (( ( ) .((_ ) . )_
> ( ( ) ( ( ) ) ) . ) ( )
> ( ( ( ( ) ( _ ( _) ). ) . ) ) ( )
> ( ( ( ) ( ) ( )) ) _)( ) ) )
> ( ( ( \ ) ( (_ ( ) ( ) ) ) ) )) ( )
> ( ( ( ( (_ ( ) ( _ ) ) ( ) ) )
> ( ( ( ( ( ) (_ ) ) ) _) ) _( ( )
> (( ( )( ( _ ) _) _(_ ( (_ )
> (_((__(_(__(( ( ( | ) ) ) )_))__))_)___)
> ((__) \\||lll|l||/// \_))
> ( /(/ ( ) ) )\ )
> ( ( ( ( | | ) ) )\ )
> ( /(| / ( )) ) ) )) )
> ( ( ((((_(|)_))))) )
> ( ||\(|(|)|/|| )
> ( |(||(||)|||| )
> ( //|/l|||)|\\ \ )
> (/ / // /|//||||\\ \ \ \ _)
> -------------------------------------------------------------------------------
> Node: ...
> -------------------------------------------------------------------------------
> Traceback (most recent call last):
> File "/lib/python3.6/site-packages/flask/app.py", line 2446, in wsgi_app
> response = self.full_dispatch_request()
> File "/lib/python3.6/site-packages/flask/app.py", line 1951, in full_dispatch_request
> rv = self.handle_user_exception(e)
> File "/lib/python3.6/site-packages/flask/app.py", line 1820, in handle_user_exception
> reraise(exc_type, exc_value, tb)
> File "/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
> raise value
> File "/lib/python3.6/site-packages/flask/app.py", line 1949, in full_dispatch_request
> rv = self.dispatch_request()
> File "/lib/python3.6/site-packages/flask/app.py", line 1935, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
> File "/lib/python3.6/site-packages/flask_appbuilder/security/views.py", line 633, in oauth_authorized
> resp = self.appbuilder.sm.oauth_remotes[provider].authorized_response()
> KeyError: 'login'
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)