You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2016/06/26 13:51:20 UTC
kylin git commit: minor,
fix compile warnings in Dictionary and TrieDictionary
Repository: kylin
Updated Branches:
refs/heads/master 5bf6582f6 -> e5b97b0e8
minor, fix compile warnings in Dictionary and TrieDictionary
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/e5b97b0e
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/e5b97b0e
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/e5b97b0e
Branch: refs/heads/master
Commit: e5b97b0e8957e90e9563162d399f291c1dfaea6e
Parents: 5bf6582
Author: Yang Li <li...@apache.org>
Authored: Sun Jun 26 21:51:09 2016 +0800
Committer: Yang Li <li...@apache.org>
Committed: Sun Jun 26 21:51:09 2016 +0800
----------------------------------------------------------------------
.../src/main/java/org/apache/kylin/common/util/Dictionary.java | 4 ++--
.../src/main/java/org/apache/kylin/dict/TrieDictionary.java | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/e5b97b0e/core-common/src/main/java/org/apache/kylin/common/util/Dictionary.java
----------------------------------------------------------------------
diff --git a/core-common/src/main/java/org/apache/kylin/common/util/Dictionary.java b/core-common/src/main/java/org/apache/kylin/common/util/Dictionary.java
index 62386af..8c9cf55 100644
--- a/core-common/src/main/java/org/apache/kylin/common/util/Dictionary.java
+++ b/core-common/src/main/java/org/apache/kylin/common/util/Dictionary.java
@@ -42,9 +42,9 @@ import org.apache.kylin.common.KylinConfig;
*
* @author yangli9
*/
-@SuppressWarnings("serial")
abstract public class Dictionary<T> implements Serializable {
-
+ private static final long serialVersionUID = 1L;
+
// ID with all bit-1 (0xff e.g.) reserved for NULL value
public static final int[] NULL_ID = new int[] { 0, 0xff, 0xffff, 0xffffff, 0xffffffff };
http://git-wip-us.apache.org/repos/asf/kylin/blob/e5b97b0e/core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionary.java
----------------------------------------------------------------------
diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionary.java b/core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionary.java
index efff7e2..03dc76a 100644
--- a/core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionary.java
+++ b/core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionary.java
@@ -56,6 +56,7 @@ import com.google.common.base.Preconditions;
*/
@SuppressWarnings({ "rawtypes", "unchecked" })
public class TrieDictionary<T> extends Dictionary<T> {
+ private static final long serialVersionUID = 1L;
public static final byte[] HEAD_MAGIC = new byte[] { 0x54, 0x72, 0x69, 0x65, 0x44, 0x69, 0x63, 0x74 }; // "TrieDict"
public static final int HEAD_SIZE_I = HEAD_MAGIC.length;