You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2021/09/24 17:55:00 UTC
[jira] [Comment Edited] (CASSANDRA-16987) CQLSH shell script will
fail on Python 3.10
[ https://issues.apache.org/jira/browse/CASSANDRA-16987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419904#comment-17419904 ]
Ekaterina Dimitrova edited comment on CASSANDRA-16987 at 9/24/21, 5:54 PM:
---------------------------------------------------------------------------
[~Bowen Song] all valid questions and comments. Let me clarify a bit.
{quote}I can see the test result is 7 failures (+4) , 960 skipped (-36)
{quote}
I submitted your patch to Jenkins dev which is accessible for testing patches pre-commit by PMC and committers. In that sense the comparison you see is to other patches tested there and not to the official [Jenkins post-commit builds history|https://jenkins-cm4.apache.org/]. What we do is comparing to the post-commit builds whether we introduced something new or there is history around some of the tests If we are not sure whether the test was broken by us or not. We also look at already opened tickets for tests issues - [this Jira filter|https://issues.apache.org/jira/issues/?filter=12350869], linked by Josh in one of the [project updates|https://lists.apache.org/thread.html/r681bcfcfa938569ae7fb86c0c309ee7d84558f1cc07eb2c1a30468c7%40%3Cdev.cassandra.apache.org%3E] on the mailing list. On a side note, we try to open also tickets for unrelated to our patch failures that no one has reported yet.
Unfortunately, only committers and PMC members can submit Jenkins dev CI runs. But you might want to explore Circle CI. (Just please bear in mind that if you use LOWRES resources not all dtests will be able to run as they require more resources. Please contact me in Slack if you need more help with this or some info for the higher resources.)
More information about our test environment can be found [here|https://cassandra.apache.org/_/development/testing.html]
I also agree that the mentioned failures are not related to your patch.
* [dtest-novnode.scrub_test.TestScrubIndexes.test_scrub_collections_table|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1141/testReport/junit/dtest-novnode.scrub_test/TestScrubIndexes/test_scrub_collections_table/] - CASSANDRA-16954
* [org.apache.cassandra.net.ConnectionTest.testMessageDeliveryOnReconnect|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1141/testReport/junit/org.apache.cassandra.net/ConnectionTest/testMessageDeliveryOnReconnect/] - CASSANDRA-16677
The rest of the failures seem like infrastructure known issues.
[~brandon.williams], if you don't have any other opinion, I can push also 4.0 CI and commit. I don't expect any difference to what we saw but for completeness and to prevent any future unpleasant surprises.
was (Author: e.dimitrova):
[~Bowen Song] all valid questions and comments. Let me clarify a bit.
{quote}I can see the test result is 7 failures (+4) , 960 skipped (-36)
{quote}
I submitted your patch to Jenkins dev which is accessible for testing patches pre-commit by PMC and committers. In that sense the comparison you see is to other patches tested there and not to the official [Jenkins post-commit builds history|https://jenkins-cm4.apache.org/]. What we do is checking there whether we introduced something new or there is history around some of the tests If we are not sure whether the test was broken by us or not. We also look at already opened tickets for tests issues - [this Jira filter|https://issues.apache.org/jira/issues/?filter=12350869], linked by Josh in one of the [project updates|https://lists.apache.org/thread.html/r681bcfcfa938569ae7fb86c0c309ee7d84558f1cc07eb2c1a30468c7%40%3Cdev.cassandra.apache.org%3E] on the mailing list. On a side note, we try to open also tickets for unrelated to our patch failures that no one has reported yet.
Unfortunately, only committers and PMC members can submit Jenkins dev CI runs. But you might want to explore Circle CI. (Just please bear in mind that if you use LOWRES resources not all dtests will be able to run as they require more resources. Please contact me in Slack if you need more help with this or some info for the higher resources.)
More information about our test environment can be found [here|https://cassandra.apache.org/_/development/testing.html]
I also agree that the mentioned failures are not related to your patch.
* [dtest-novnode.scrub_test.TestScrubIndexes.test_scrub_collections_table|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1141/testReport/junit/dtest-novnode.scrub_test/TestScrubIndexes/test_scrub_collections_table/] - CASSANDRA-16954
* [org.apache.cassandra.net.ConnectionTest.testMessageDeliveryOnReconnect|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1141/testReport/junit/org.apache.cassandra.net/ConnectionTest/testMessageDeliveryOnReconnect/] - CASSANDRA-16677
The rest of the failures seem like infrastructure known issues.
[~brandon.williams], if you don't have any other opinion, I can push also 4.0 CI and commit. I don't expect any difference to what we saw but for completeness and to prevent any future unpleasant surprises.
> CQLSH shell script will fail on Python 3.10
> -------------------------------------------
>
> Key: CASSANDRA-16987
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16987
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/cqlsh
> Reporter: Bowen Song
> Assignee: Bowen Song
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The `is_supported_version()` function performs a lexicographical comparison between the Python version number in the format of `MAJOR.MINOR` with `3.6`. This works as expected if the Python version number is between `3.0` and `3.9` (inclusive), but will produce an unexpected result if the Python version number is `3.10` or above.
> Recommended fix is to split the version number into two integers, `$version_major` and `$version_minor` and then compare them to `3` and `6` respectively.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org