You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Fabrice BELLINGARD (JIRA)" <ji...@codehaus.org> on 2007/07/06 10:47:13 UTC
[jira] Created: (MASSEMBLY-226) Filters as read-only parameter can
break the assembly build of a multi-module project
Filters as read-only parameter can break the assembly build of a multi-module project
-------------------------------------------------------------------------------------
Key: MASSEMBLY-226
URL: http://jira.codehaus.org/browse/MASSEMBLY-226
Project: Maven 2.x Assembly Plugin
Issue Type: Bug
Affects Versions: 2.2-beta-1
Reporter: Fabrice BELLINGARD
Attachments: FiltersTest.zip
When I specify <build><filters> in the root project for filtering files of an assembly, then running "assembly:assembly" breaks. This is because <build><filters> configuration is inherited in the modules, and Maven does not correctly inherit this configuration (see MNG-2445).
I attached an example project to test this:
- run "assembly:attached" on the root project: it works fine
- run "assembly:assembly" on the root project: it breaks
I think the "filters" argument of the assembly plugin should not be read-only. Instead, it should be possible to redefine it locally, or leave it blank if we want the plugin to take the <build><filters> definition instead.
What do you think of this? I can work on this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-226) Filters as read-only parameter
can break the assembly build of a multi-module project
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101476 ]
John Casey commented on MASSEMBLY-226:
--------------------------------------
sounds like a fine idea to me, and an easy fix. We'll have to make sure we have the sample build in the integration tests, though...as that helps to explain that we've made a conscious design choice on this point.
> Filters as read-only parameter can break the assembly build of a multi-module project
> -------------------------------------------------------------------------------------
>
> Key: MASSEMBLY-226
> URL: http://jira.codehaus.org/browse/MASSEMBLY-226
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Reporter: Fabrice BELLINGARD
> Attachments: FiltersNotReadOnly.patch, FiltersTest.zip
>
>
> When I specify <build><filters> in the root project for filtering files of an assembly, then running "assembly:assembly" breaks. This is because <build><filters> configuration is inherited in the modules, and Maven does not correctly inherit this configuration (see MNG-2445).
> I attached an example project to test this:
> - run "assembly:attached" on the root project: it works fine
> - run "assembly:assembly" on the root project: it breaks
> I think the "filters" argument of the assembly plugin should not be read-only. Instead, it should be possible to redefine it locally, or leave it blank if we want the plugin to take the <build><filters> definition instead.
> What do you think of this? I can work on this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-226) Filters as read-only parameter can
break the assembly build of a multi-module project
Posted by "Fabrice BELLINGARD (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fabrice BELLINGARD updated MASSEMBLY-226:
-----------------------------------------
Attachment: FiltersNotReadOnly.patch
Patch to allow users to specify filters locally tothe assembly plugin. If not specified, the filters get the ${project.build.filters} value.
> Filters as read-only parameter can break the assembly build of a multi-module project
> -------------------------------------------------------------------------------------
>
> Key: MASSEMBLY-226
> URL: http://jira.codehaus.org/browse/MASSEMBLY-226
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Reporter: Fabrice BELLINGARD
> Attachments: FiltersNotReadOnly.patch, FiltersTest.zip
>
>
> When I specify <build><filters> in the root project for filtering files of an assembly, then running "assembly:assembly" breaks. This is because <build><filters> configuration is inherited in the modules, and Maven does not correctly inherit this configuration (see MNG-2445).
> I attached an example project to test this:
> - run "assembly:attached" on the root project: it works fine
> - run "assembly:assembly" on the root project: it breaks
> I think the "filters" argument of the assembly plugin should not be read-only. Instead, it should be possible to redefine it locally, or leave it blank if we want the plugin to take the <build><filters> definition instead.
> What do you think of this? I can work on this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-226) Filters as read-only parameter can
break the assembly build of a multi-module project
Posted by "Fabrice BELLINGARD (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fabrice BELLINGARD updated MASSEMBLY-226:
-----------------------------------------
Fix Version/s: 2.2-beta-2
> Filters as read-only parameter can break the assembly build of a multi-module project
> -------------------------------------------------------------------------------------
>
> Key: MASSEMBLY-226
> URL: http://jira.codehaus.org/browse/MASSEMBLY-226
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Reporter: Fabrice BELLINGARD
> Assignee: Fabrice BELLINGARD
> Fix For: 2.2-beta-2
>
> Attachments: FiltersNotReadOnly.patch, FiltersTest.zip
>
>
> When I specify <build><filters> in the root project for filtering files of an assembly, then running "assembly:assembly" breaks. This is because <build><filters> configuration is inherited in the modules, and Maven does not correctly inherit this configuration (see MNG-2445).
> I attached an example project to test this:
> - run "assembly:attached" on the root project: it works fine
> - run "assembly:assembly" on the root project: it breaks
> I think the "filters" argument of the assembly plugin should not be read-only. Instead, it should be possible to redefine it locally, or leave it blank if we want the plugin to take the <build><filters> definition instead.
> What do you think of this? I can work on this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MASSEMBLY-226) Filters as read-only parameter can
break the assembly build of a multi-module project
Posted by "Fabrice BELLINGARD (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fabrice BELLINGARD closed MASSEMBLY-226.
----------------------------------------
Resolution: Fixed
Fixed in trunk, with an integration test.
> Filters as read-only parameter can break the assembly build of a multi-module project
> -------------------------------------------------------------------------------------
>
> Key: MASSEMBLY-226
> URL: http://jira.codehaus.org/browse/MASSEMBLY-226
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Reporter: Fabrice BELLINGARD
> Assignee: Fabrice BELLINGARD
> Attachments: FiltersNotReadOnly.patch, FiltersTest.zip
>
>
> When I specify <build><filters> in the root project for filtering files of an assembly, then running "assembly:assembly" breaks. This is because <build><filters> configuration is inherited in the modules, and Maven does not correctly inherit this configuration (see MNG-2445).
> I attached an example project to test this:
> - run "assembly:attached" on the root project: it works fine
> - run "assembly:assembly" on the root project: it breaks
> I think the "filters" argument of the assembly plugin should not be read-only. Instead, it should be possible to redefine it locally, or leave it blank if we want the plugin to take the <build><filters> definition instead.
> What do you think of this? I can work on this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira