You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/05 09:49:00 UTC
[jira] [Commented] (ARTEMIS-1728) Reclaim memory when page cursor
complete
[ https://issues.apache.org/jira/browse/ARTEMIS-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385868#comment-16385868 ]
ASF GitHub Bot commented on ARTEMIS-1728:
-----------------------------------------
GitHub user shoukunhuai opened a pull request:
https://github.com/apache/activemq-artemis/pull/1929
ARTEMIS-1728 Reclaim memory when page cursor complete
Free hash set used to hold page position for acks and removed refs.
The two set is cleared, but they still hold a big array.
It is safe to replace the old one with empty set.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shoukunhuai/activemq-artemis reclaim_hashmap
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1929.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1929
----
commit 6d445c5d6485ed5ca65ea5718905a84ca6d5eb9b
Author: huaishk <sh...@...>
Date: 2018-03-05T09:32:29Z
ARTEMIS-1728 Reclaim memory when page cursor complete
Free hash set used to hold page position for acks and removed refs.
The two set is cleared, but they still hold a big array.
It is safe to replace the old one with empty set.
----
> Reclaim memory when page cursor complete
> ----------------------------------------
>
> Key: ARTEMIS-1728
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1728
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: shoukun huai
> Priority: Minor
>
> Reclaim memory when page cursor completes.
> There are two hash set used to hold page position for acks and removed message references. Both are cleared when page cursor is marked done. While clear a hash set does not reclaim memory the under line hash map claimed before.
> Things go bad when you have an address with many bindings and one of them consumes slowly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)