You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vladimir Beliaev (JIRA)" <ji...@apache.org> on 2007/04/18 15:02:15 UTC
[jira] Created: (HARMONY-3696) [drlvm][kernel] removing PolicyUtils
& SecurityUtils from kernel classes is required
[drlvm][kernel] removing PolicyUtils & SecurityUtils from kernel classes is required
------------------------------------------------------------------------------------
Key: HARMONY-3696
URL: https://issues.apache.org/jira/browse/HARMONY-3696
Project: Harmony
Issue Type: Sub-task
Environment: any
Reporter: Vladimir Beliaev
Next pack of warnings (15) is produced by PolicyUtils.
it turned out that PolicyUtils.java is already defined in classlib component (in different package). It differs from DRLVM version only in use of generics (classlib version does it correctly).
There is another duplicated class - SecurityUtils.
Both PolicyUtils & SecurityUtils do not seem to be really "kernel"
- they do not have any VM specific native defined (no native at all)
- they do not use kernel classes private API (like package private field of java/lang/Class for example)
So, I guess both duplication are to be removed ffrom kernel classes.
Thanks
Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3696) [drlvm][kernel] removing
PolicyUtils & SecurityUtils from kernel classes is required
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-3696.
----------------------------------------
Resolution: Fixed
Patch applied at 531480. Please check that it was applied as expected.
> [drlvm][kernel] removing PolicyUtils & SecurityUtils from kernel classes is required
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-3696
> URL: https://issues.apache.org/jira/browse/HARMONY-3696
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Assigned To: Gregory Shimansky
> Attachments: H3696.patch, H3696.patch, H3696.sh
>
>
> Next pack of warnings (15) is produced by PolicyUtils.
> it turned out that PolicyUtils.java is already defined in classlib component (in different package). It differs from DRLVM version only in use of generics (classlib version does it correctly).
> There is another duplicated class - SecurityUtils.
> Both PolicyUtils & SecurityUtils do not seem to be really "kernel"
> - they do not have any VM specific native defined (no native at all)
> - they do not use kernel classes private API (like package private field of java/lang/Class for example)
> So, I guess both duplication are to be removed ffrom kernel classes.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3696) [drlvm][kernel] removing PolicyUtils
& SecurityUtils from kernel classes is required
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Beliaev updated HARMONY-3696:
--------------------------------------
Attachment: H3696.patch
Added patch which removeed PolicyUtils & SecurityUtils from kernel classes & updates the package name in customer classes.
> [drlvm][kernel] removing PolicyUtils & SecurityUtils from kernel classes is required
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-3696
> URL: https://issues.apache.org/jira/browse/HARMONY-3696
> Project: Harmony
> Issue Type: Sub-task
> Environment: any
> Reporter: Vladimir Beliaev
> Attachments: H3696.patch
>
>
> Next pack of warnings (15) is produced by PolicyUtils.
> it turned out that PolicyUtils.java is already defined in classlib component (in different package). It differs from DRLVM version only in use of generics (classlib version does it correctly).
> There is another duplicated class - SecurityUtils.
> Both PolicyUtils & SecurityUtils do not seem to be really "kernel"
> - they do not have any VM specific native defined (no native at all)
> - they do not use kernel classes private API (like package private field of java/lang/Class for example)
> So, I guess both duplication are to be removed ffrom kernel classes.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3696) [drlvm][kernel] removing PolicyUtils
& SecurityUtils from kernel classes is required
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Beliaev updated HARMONY-3696:
--------------------------------------
Attachment: H3696.patch
Oops, you are right, Alexey. I doube checked the content of PolicyUtils & SecurityUtils, and:
1. the PolicyUtils is just removed;
2. SecurityUtils is kept in DRLVM + I make it to be close to CLASSLIB version (using final ACC_CACHE instead of map). Still I did not make it internationalized to avoid Kernel Classes implementation dependency from CLASSLIB implementation classes (org.apache.harmony.security.internal.nls.Messages).
Thanks
Vladimir Beliaev
> [drlvm][kernel] removing PolicyUtils & SecurityUtils from kernel classes is required
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-3696
> URL: https://issues.apache.org/jira/browse/HARMONY-3696
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Assigned To: Gregory Shimansky
> Attachments: H3696.patch, H3696.patch
>
>
> Next pack of warnings (15) is produced by PolicyUtils.
> it turned out that PolicyUtils.java is already defined in classlib component (in different package). It differs from DRLVM version only in use of generics (classlib version does it correctly).
> There is another duplicated class - SecurityUtils.
> Both PolicyUtils & SecurityUtils do not seem to be really "kernel"
> - they do not have any VM specific native defined (no native at all)
> - they do not use kernel classes private API (like package private field of java/lang/Class for example)
> So, I guess both duplication are to be removed ffrom kernel classes.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3696) [drlvm][kernel] removing PolicyUtils
& SecurityUtils from kernel classes is required
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Beliaev updated HARMONY-3696:
--------------------------------------
Attachment: H3696.sh
The attached script is to be executed after the attached patch is applied - this script moves SecurityUtils.java to different package.
Gregory, please go ahead with comitting (while Aelxey is sleeping ...)
Thanks
Vladimir Beliaev
> [drlvm][kernel] removing PolicyUtils & SecurityUtils from kernel classes is required
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-3696
> URL: https://issues.apache.org/jira/browse/HARMONY-3696
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Assigned To: Gregory Shimansky
> Attachments: H3696.patch, H3696.patch, H3696.sh
>
>
> Next pack of warnings (15) is produced by PolicyUtils.
> it turned out that PolicyUtils.java is already defined in classlib component (in different package). It differs from DRLVM version only in use of generics (classlib version does it correctly).
> There is another duplicated class - SecurityUtils.
> Both PolicyUtils & SecurityUtils do not seem to be really "kernel"
> - they do not have any VM specific native defined (no native at all)
> - they do not use kernel classes private API (like package private field of java/lang/Class for example)
> So, I guess both duplication are to be removed ffrom kernel classes.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3696) [drlvm][kernel] removing PolicyUtils
& SecurityUtils from kernel classes is required
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Beliaev updated HARMONY-3696:
--------------------------------------
Patch Info: [Patch Available]
> [drlvm][kernel] removing PolicyUtils & SecurityUtils from kernel classes is required
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-3696
> URL: https://issues.apache.org/jira/browse/HARMONY-3696
> Project: Harmony
> Issue Type: Sub-task
> Environment: any
> Reporter: Vladimir Beliaev
> Attachments: H3696.patch
>
>
> Next pack of warnings (15) is produced by PolicyUtils.
> it turned out that PolicyUtils.java is already defined in classlib component (in different package). It differs from DRLVM version only in use of generics (classlib version does it correctly).
> There is another duplicated class - SecurityUtils.
> Both PolicyUtils & SecurityUtils do not seem to be really "kernel"
> - they do not have any VM specific native defined (no native at all)
> - they do not use kernel classes private API (like package private field of java/lang/Class for example)
> So, I guess both duplication are to be removed ffrom kernel classes.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3696) [drlvm][kernel] removing PolicyUtils
& SecurityUtils from kernel classes is required
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-3696.
--------------------------------------
No response, assuming ok.
> [drlvm][kernel] removing PolicyUtils & SecurityUtils from kernel classes is required
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-3696
> URL: https://issues.apache.org/jira/browse/HARMONY-3696
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Assignee: Gregory Shimansky
> Attachments: H3696.patch, H3696.patch, H3696.sh
>
>
> Next pack of warnings (15) is produced by PolicyUtils.
> it turned out that PolicyUtils.java is already defined in classlib component (in different package). It differs from DRLVM version only in use of generics (classlib version does it correctly).
> There is another duplicated class - SecurityUtils.
> Both PolicyUtils & SecurityUtils do not seem to be really "kernel"
> - they do not have any VM specific native defined (no native at all)
> - they do not use kernel classes private API (like package private field of java/lang/Class for example)
> So, I guess both duplication are to be removed ffrom kernel classes.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3696) [drlvm][kernel] removing PolicyUtils
& SecurityUtils from kernel classes is required
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov updated HARMONY-3696:
-------------------------------------
Component/s: DRLVM
> [drlvm][kernel] removing PolicyUtils & SecurityUtils from kernel classes is required
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-3696
> URL: https://issues.apache.org/jira/browse/HARMONY-3696
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Assigned To: Gregory Shimansky
> Attachments: H3696.patch
>
>
> Next pack of warnings (15) is produced by PolicyUtils.
> it turned out that PolicyUtils.java is already defined in classlib component (in different package). It differs from DRLVM version only in use of generics (classlib version does it correctly).
> There is another duplicated class - SecurityUtils.
> Both PolicyUtils & SecurityUtils do not seem to be really "kernel"
> - they do not have any VM specific native defined (no native at all)
> - they do not use kernel classes private API (like package private field of java/lang/Class for example)
> So, I guess both duplication are to be removed ffrom kernel classes.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3696) [drlvm][kernel] removing
PolicyUtils & SecurityUtils from kernel classes is required
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reassigned HARMONY-3696:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm][kernel] removing PolicyUtils & SecurityUtils from kernel classes is required
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-3696
> URL: https://issues.apache.org/jira/browse/HARMONY-3696
> Project: Harmony
> Issue Type: Sub-task
> Environment: any
> Reporter: Vladimir Beliaev
> Assigned To: Gregory Shimansky
> Attachments: H3696.patch
>
>
> Next pack of warnings (15) is produced by PolicyUtils.
> it turned out that PolicyUtils.java is already defined in classlib component (in different package). It differs from DRLVM version only in use of generics (classlib version does it correctly).
> There is another duplicated class - SecurityUtils.
> Both PolicyUtils & SecurityUtils do not seem to be really "kernel"
> - they do not have any VM specific native defined (no native at all)
> - they do not use kernel classes private API (like package private field of java/lang/Class for example)
> So, I guess both duplication are to be removed ffrom kernel classes.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3696) [drlvm][kernel] removing
PolicyUtils & SecurityUtils from kernel classes is required
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489924 ]
Alexey Varlamov commented on HARMONY-3696:
------------------------------------------
SecurityUtils is truly kernel class, it is a part of AccessController machinery and has little sense outside of DRLVM. The duplicate class in classlib is not used and should be dropped + package name aligned in kernel one.
And I agree with PolicyUtils removal.
> [drlvm][kernel] removing PolicyUtils & SecurityUtils from kernel classes is required
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-3696
> URL: https://issues.apache.org/jira/browse/HARMONY-3696
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: any
> Reporter: Vladimir Beliaev
> Assigned To: Gregory Shimansky
> Attachments: H3696.patch
>
>
> Next pack of warnings (15) is produced by PolicyUtils.
> it turned out that PolicyUtils.java is already defined in classlib component (in different package). It differs from DRLVM version only in use of generics (classlib version does it correctly).
> There is another duplicated class - SecurityUtils.
> Both PolicyUtils & SecurityUtils do not seem to be really "kernel"
> - they do not have any VM specific native defined (no native at all)
> - they do not use kernel classes private API (like package private field of java/lang/Class for example)
> So, I guess both duplication are to be removed ffrom kernel classes.
> Thanks
> Vladimir Beliaev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.