You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/11 17:02:37 UTC

[GitHub] [shardingsphere] terrymanu opened a new pull request #7746: Remove SQLStatementContext.isReadOnly

terrymanu opened a new pull request #7746:
URL: https://github.com/apache/shardingsphere/pull/7746


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-io commented on pull request #7746: Remove SQLStatementContext.isReadOnly

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7746:
URL: https://github.com/apache/shardingsphere/pull/7746#issuecomment-706740645


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=h1) Report
   > Merging [#7746](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/858cee60d6664938ec520b9e5d5c91fc0a079a65?el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7746/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7746      +/-   ##
   ============================================
   + Coverage     75.23%   75.26%   +0.02%     
     Complexity      517      517              
   ============================================
     Files          1401     1400       -1     
     Lines         22431    22424       -7     
     Branches       4042     4040       -2     
   ============================================
     Hits          16877    16877              
   + Misses         4466     4459       -7     
     Partials       1088     1088              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...us/route/engine/ConsensusReplicationSQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/7746/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtY29uc2Vuc3VzLXJlcGxpY2F0aW9uL3NoYXJkaW5nc3BoZXJlLWNvbnNlbnN1cy1yZXBsaWNhdGlvbi1yb3V0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYXRpb24vY29uc2Vuc3VzL3JvdXRlL2VuZ2luZS9Db25zZW5zdXNSZXBsaWNhdGlvblNRTFJvdXRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...dingsphere/sql/parser/sql/common/util/SQLUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/7746/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3V0aWwvU1FMVXRpbC5qYXZh) | `34.61% <0.00%> (+3.58%)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=footer). Last update [858cee6...be2381c](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] menghaoranss merged pull request #7746: Remove SQLStatementContext.isReadOnly

Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #7746:
URL: https://github.com/apache/shardingsphere/pull/7746


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-io edited a comment on pull request #7746: Remove SQLStatementContext.isReadOnly

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #7746:
URL: https://github.com/apache/shardingsphere/pull/7746#issuecomment-706740645


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=h1) Report
   > Merging [#7746](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/858cee60d6664938ec520b9e5d5c91fc0a079a65?el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7746/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7746      +/-   ##
   ============================================
   + Coverage     75.23%   75.26%   +0.02%     
     Complexity      517      517              
   ============================================
     Files          1401     1400       -1     
     Lines         22431    22424       -7     
     Branches       4042     4040       -2     
   ============================================
     Hits          16877    16877              
   + Misses         4466     4459       -7     
     Partials       1088     1088              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...us/route/engine/ConsensusReplicationSQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/7746/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtY29uc2Vuc3VzLXJlcGxpY2F0aW9uL3NoYXJkaW5nc3BoZXJlLWNvbnNlbnN1cy1yZXBsaWNhdGlvbi1yb3V0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYXRpb24vY29uc2Vuc3VzL3JvdXRlL2VuZ2luZS9Db25zZW5zdXNSZXBsaWNhdGlvblNRTFJvdXRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...dingsphere/sql/parser/sql/common/util/SQLUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/7746/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3V0aWwvU1FMVXRpbC5qYXZh) | `34.61% <0.00%> (+3.58%)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=footer). Last update [858cee6...be2381c](https://codecov.io/gh/apache/shardingsphere/pull/7746?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org