RE: svn commit: r40146 - trunk/subversion/libsvn_fs_base/bdb

[Bert Huijben <rh...@sharpsvn.net>]

> -----Original Message-----
> From: Senthil Kumaran S [mailto:senthil@collab.net]
> Sent: woensdag 21 oktober 2009 10:22
> To: svn@subversion.tigris.org
> Subject: svn commit: r40146 - trunk/subversion/libsvn_fs_base/bdb
> 
> Author: stylesen
> Date: Wed Oct 21 01:21:53 2009
> New Revision: 40146
> 
> Log:
> Resolve some deprecation warnings.
> 
> * subversion/libsvn_fs_base/bdb/changes-table.c
>   (svn_fs_bdb__changes_fetch): Use svn_dirent_is_child().
> 
> Modified:
>    trunk/subversion/libsvn_fs_base/bdb/changes-table.c
> 
> Modified: trunk/subversion/libsvn_fs_base/bdb/changes-table.c
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_base/bdb/ch
> anges-table.c?pathrev=40146&r1=40145&r2=40146
> =======================================================================
> =======
> --- trunk/subversion/libsvn_fs_base/bdb/changes-table.c	Wed Oct 21
> 00:48:55 2009	(r40145)
> +++ trunk/subversion/libsvn_fs_base/bdb/changes-table.c	Wed Oct 21
> 01:21:53 2009	(r40146)
> @@ -322,7 +322,7 @@ svn_fs_bdb__changes_fetch(apr_hash_t **c
>                  continue;
> 
>                /* If we come across a child of our path, remove it. */
> -              if (svn_path_is_child(change->path, hashkey, subpool))
> +              if (svn_dirent_is_child(change->path, hashkey, subpool))
>                  apr_hash_set(changes, hashkey, klen, NULL);

If this is an in-database path (I guess it is) and not an on-disk path this
should use svn_uri_*() or svn_relpath_*(). Dirents use platform specific
rules. 

E.g. c:hi is a valid dirent on posix (and in the repository) but is
translated to C:hi (file 'hi' in the current directory of 'C:') when
canonicalizing on Windows.

	Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2409762