You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/30 12:15:01 UTC
[GitHub] [iceberg] chenjunjiedada opened a new pull request #1274: Core: Fix the wrong imported Lists from commons
chenjunjiedada opened a new pull request #1274:
URL: https://github.com/apache/iceberg/pull/1274
This fixes a runtime error. Spark 3 uses apache common 1.8.1, while we use apache commons 1.19 and exclude it. So it throws no class found when running in a real cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] HeartSaVioR commented on pull request #1274: Core: Fix the wrong imported Lists from commons
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #1274:
URL: https://github.com/apache/iceberg/pull/1274#issuecomment-666357768
Looks OK to me once Travis CI build passes - the usage of Lists is only `newArrayList()` which I normally expect libs provide this won't show major difference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] chenjunjiedada commented on pull request #1274: Core: Fix the wrong imported Lists from commons
Posted by GitBox <gi...@apache.org>.
chenjunjiedada commented on pull request #1274:
URL: https://github.com/apache/iceberg/pull/1274#issuecomment-666856567
@rdblue, No problem! Please go ahead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1274: Core: Fix the wrong imported Lists from commons
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1274:
URL: https://github.com/apache/iceberg/pull/1274#issuecomment-666852771
Thanks for fixing this, @chenjunjiedada! I hadn't checked PRs yet today (I attended a conference) so I didn't notice you'd already fixed it and posted a PR myself, #1278. I included an update to ban imports from this package to avoid the problem in the future, so I'd like to merge that one. I've added you as a co-author of it so you'll get credit when it is merged. Is that okay with you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] chenjunjiedada closed pull request #1274: Core: Fix the wrong imported Lists from commons
Posted by GitBox <gi...@apache.org>.
chenjunjiedada closed pull request #1274:
URL: https://github.com/apache/iceberg/pull/1274
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org