You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "srkreddy1238 (via GitHub)" <gi...@apache.org> on 2023/05/31 07:02:06 UTC

[GitHub] [tvm] srkreddy1238 commented on a diff in pull request #14922: [OpenCLML] Reactor and introduce on chip memory and memory planner

srkreddy1238 commented on code in PR #14922:
URL: https://github.com/apache/tvm/pull/14922#discussion_r1211180602


##########
python/tvm/relay/op/contrib/clml.py:
##########
@@ -394,7 +447,7 @@ def check_default_op(extract):
         ("clml.minimum", is_op("minimum")(wildcard(), wildcard()), check_binary_op),
         ("clml.maximum", is_op("maximum")(wildcard(), wildcard()), check_binary_op),
         ("clml.softmax", is_op("nn.softmax")(wildcard()), check_softmax_op),
-        ("clml.reshape", is_op("reshape")(wildcard()), check_default_op),
+        # ("clml.reshape", is_op("reshape")(wildcard()), check_default_op),

Review Comment:
   There are some issues with reshape with few networks. Letting it to take TVM path for now. Need to revisit later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org