You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "sungwy (via GitHub)" <gi...@apache.org> on 2025/05/02 01:52:30 UTC
[PR] Reorder `validation_history` parameters to be more idiomatic [iceberg-python]
sungwy opened a new pull request, #1959:
URL: https://github.com/apache/iceberg-python/pull/1959
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Nit: the current order (`to_snapshot` before `from_snapshot`) is unexpected and [error-prone](https://github.com/apache/iceberg-python/pull/1938/files#r2070985497).
This PR proposes to reorder these parameters in `validation_history` and `ancestors_between` so that it is more idiomatic.
# Are these changes tested?
Yes, through integration and unit tests
# Are there any user-facing changes?
Yes, but these functions were just introduced (no releases were made yet with these functions)
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Reorder `validation_history` parameters to be more idiomatic [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #1959:
URL: https://github.com/apache/iceberg-python/pull/1959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org