You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/11 06:08:33 UTC
[GitHub] [spark] itholic opened a new pull request #34550: Add an option to silence advice for pandas API on Spark.
itholic opened a new pull request #34550:
URL: https://github.com/apache/spark/pull/34550
### What changes were proposed in this pull request?
This PR proposes to add an option `display.log_advice` to determine whether or not issue the advice message for pandas API on Spark.
```python
psdf = ps.DataFrame({"A": [1, 2, 3]})
# Turn on the advice log
with ps.option_context("display.log_advice", True):
psdf.to_pandas()
.../spark/python/pyspark/pandas/utils.py:970: UserWarning: `to_pandas` loads all data into the driver's memory. It should only be used if the resulting pandas DataFrame is expected to be small.
warnings.warn(message, UserWarning)
A
0 1
1 2
2 3
# Turn off the advice log
with ps.option_context("display.log_advice", False):
psdf.to_pandas()
A
0 1
1 2
2 3
```
### Why are the changes needed?
Sometimes the messages are too verbose to display, so someone might not need to see the advice log.
So we'd better give an option to turn on/off the advice messages.
### Does this PR introduce _any_ user-facing change?
Users can use new option, `display.log_advice`.
### How was this patch tested?
It's tested in `tests/test_config.py` by automatically adding to the existing config list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966061398
**[Test build #145088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145088/testReport)** for PR 34550 at commit [`02aa1d3`](https://github.com/apache/spark/commit/02aa1d3938b3ea3a678cf0c7f70325bd66bb9399).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class PandasAPIOnSparkAdviceWarning(Warning):`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966075657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966737945
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966043897
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145084/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34550: Add an option to silence advice for pandas API on Spark.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966018168
**[Test build #145084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145084/testReport)** for PR 34550 at commit [`56d89c0`](https://github.com/apache/spark/commit/56d89c06bb0136cac02d21b9e715eeb9ff2ba896).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966117470
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49557/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966043897
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145084/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966074989
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49557/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966075657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34550: [SPARK-37263][PYTHON] Add an option to silence advice for pandas API on Spark.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966018168
**[Test build #145084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145084/testReport)** for PR 34550 at commit [`56d89c0`](https://github.com/apache/spark/commit/56d89c06bb0136cac02d21b9e715eeb9ff2ba896).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966068922
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49553/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34550: [SPARK-37263][PYTHON] Add an option to silence advice for pandas API on Spark.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966032558
**[Test build #145084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145084/testReport)** for PR 34550 at commit [`56d89c0`](https://github.com/apache/spark/commit/56d89c06bb0136cac02d21b9e715eeb9ff2ba896).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966117470
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49557/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34550: [SPARK-37263][PYTHON] Add an option to silence advice for pandas API on Spark.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966037668
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49553/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966045314
**[Test build #145088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145088/testReport)** for PR 34550 at commit [`02aa1d3`](https://github.com/apache/spark/commit/02aa1d3938b3ea3a678cf0c7f70325bd66bb9399).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966117381
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49557/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34550:
URL: https://github.com/apache/spark/pull/34550#issuecomment-966045314
**[Test build #145088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145088/testReport)** for PR 34550 at commit [`02aa1d3`](https://github.com/apache/spark/commit/02aa1d3938b3ea3a678cf0c7f70325bd66bb9399).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34550: [SPARK-37263][PYTHON] Add PandasAPIOnSparkAdviceWarning class
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34550:
URL: https://github.com/apache/spark/pull/34550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org