You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/02 18:04:46 UTC
[GitHub] [incubator-tvm] trevor-m opened a new pull request #5224:
[Relay][AnnotateTarget] Propagate types during Annotation + Support Tuple
trevor-m opened a new pull request #5224: [Relay][AnnotateTarget] Propagate types during Annotation + Support Tuple
URL: https://github.com/apache/incubator-tvm/pull/5224
This PR includes two fixes to AnnotateTarget pass and testcases for each.
1. Include TupleNode in annotation when args are also supported. This prevents Tuple from breaking a model into multiple subgraphs when all ops are supported by the external codegen. This is needed to support annotation of concatenate op. Added `test_tuple` test for this fix.
2. AnnotateTarget is mutating the graph by adding `compiler.begin` and `compiler.end` nodes. The modified nodes are then passed to the registered FTVMAnnotateTarget python functions. Therefore since the modified nodes did not have type information yet, the python annotation functions could not access the checked_type of the args. I fixed this by manually copying checked_type when new nodes are created in the AnnotateTarget pass. However, we should consider refactoring this pass so that only the unmodified original nodes are passed to FTVMAnnotateTarget functions. Added `test_type_propagation` for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] trevor-m closed pull request #5224:
[Relay][AnnotateTarget] Propagate types during Annotation + Support Tuple
Posted by GitBox <gi...@apache.org>.
trevor-m closed pull request #5224: [Relay][AnnotateTarget] Propagate types during Annotation + Support Tuple
URL: https://github.com/apache/incubator-tvm/pull/5224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] trevor-m commented on issue #5224:
[Relay][AnnotateTarget] Propagate types during Annotation + Support Tuple
Posted by GitBox <gi...@apache.org>.
trevor-m commented on issue #5224: [Relay][AnnotateTarget] Propagate types during Annotation + Support Tuple
URL: https://github.com/apache/incubator-tvm/pull/5224#issuecomment-608016870
@zhiics @comaniac @mbaret
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] comaniac commented on issue #5224:
[Relay][AnnotateTarget] Propagate types during Annotation + Support Tuple
Posted by GitBox <gi...@apache.org>.
comaniac commented on issue #5224: [Relay][AnnotateTarget] Propagate types during Annotation + Support Tuple
URL: https://github.com/apache/incubator-tvm/pull/5224#issuecomment-608756703
@trevor-m according to our offline discussion, I'll file a PR including your changes, so please feel free to close this one. Thanks :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services