[jira] Commented: (MAPREDUCE-1290) DBOutputFormat does not support rewriteBatchedStatements when using MySQL jdbc drivers

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789801#action_12789801 ] 

Hadoop QA commented on MAPREDUCE-1290:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12427830/MAPREDUCE-1290.patch
  against trunk revision 889786.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/323/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/323/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/323/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/323/console

This message is automatically generated.

> DBOutputFormat does not support rewriteBatchedStatements when using MySQL jdbc drivers
> --------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1290
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1290
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Joe Crobak
>         Attachments: MAPREDUCE-1290.patch
>
>
> The DBOutputFormat adds a semi-colon to the end of the INSERT statement that it uses to save fields to the database.  Semicolons are typically used in command line programs but are not needed when using the JDBC API.  In this case, the stray semi-colon breaks rewriteBatchedStatement support. See: http://forums.mysql.com/read.php?39,271526,271526#msg-271526 for an example.
> In my use case, rewriteBatchedStatement is very useful because it increases the speed of inserts and reduces memory consumption.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.