You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/10 15:18:14 UTC
Re: Review Request 42342: Added a new test cases for revive offer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/
-----------------------------------------------------------
(Updated 四月 10, 2016, 1:18 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
Changes
-------
Alex and Vinod, can you please help review? Thanks.
Bugs: MESOS-4387
https://issues.apache.org/jira/browse/MESOS-4387
Repository: mesos
Description
-------
Added a new test cases for revive offer.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp a5dd57a4e0c244fb099433eb7b5777982698ebfd
Diff: https://reviews.apache.org/r/42342/diff/
Testing
-------
make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
Thanks,
Guangya Liu
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review128044
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39628, 42342]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 10, 2016, 1:18 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 1:18 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp a5dd57a4e0c244fb099433eb7b5777982698ebfd
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 13, 2016, 7:37 a.m., Alexander Rukletsov wrote:
> >
Thanks Alex, I create a patch here https://reviews.apache.org/r/46140/
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review128627
-----------------------------------------------------------
On 四月 10, 2016, 1:18 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated 四月 10, 2016, 1:18 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp a5dd57a4e0c244fb099433eb7b5777982698ebfd
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review128627
-----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 3040)
<https://reviews.apache.org/r/42342/#comment192106>
s/recovered/declined
framework declines resources, allocator recovers
src/tests/hierarchical_allocator_tests.cpp (line 3046)
<https://reviews.apache.org/r/42342/#comment192108>
All other tests call it "batch allocation" now. Consistency in naming is important to avoid confusion!
src/tests/hierarchical_allocator_tests.cpp (line 3077)
<https://reviews.apache.org/r/42342/#comment192107>
Let's stay consistent and call it "a batch allocation"
- Alexander Rukletsov
On April 10, 2016, 1:18 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 1:18 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp a5dd57a4e0c244fb099433eb7b5777982698ebfd
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review128511
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 10, 2016, 1:18 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 1:18 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp a5dd57a4e0c244fb099433eb7b5777982698ebfd
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>