You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/24 13:48:36 UTC
[GitHub] [pulsar] yuruguo opened a new pull request, #19048: [improve][client] Add unified newTableView method in PulsarClient
yuruguo opened a new pull request, #19048:
URL: https://github.com/apache/pulsar/pull/19048
### Motivation
Add unified `newTableView` method and replace `newTableViewBuilder` in PulsarClient, which could consistent with `newProducer` / `newConsumer` / `newReader` / `newTransaction`.
<img width="451" alt="image" src="https://user-images.githubusercontent.com/13013780/209438651-d2ba1409-b2ea-4673-8b7c-6ebc879b94ff.png">
### Modifications
- Add `newTableView()` method in PulsarClient
- Add `newTableView(Schema)` method and deprecated `newTableViewBuilder(Schema)` method in PulsarClient
### Documentation
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19048:
URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1364535711
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/19048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19048](https://codecov.io/gh/apache/pulsar/pull/19048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9434e06) into [master](https://codecov.io/gh/apache/pulsar/commit/d8569cd4ec6da14f8b2b9338db1ed2f6a3eacf0a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d8569cd) will **decrease** coverage by `10.09%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/pulsar/pull/19048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19048 +/- ##
=============================================
- Coverage 46.82% 36.72% -10.10%
+ Complexity 10567 1957 -8610
=============================================
Files 709 209 -500
Lines 69421 14436 -54985
Branches 7449 1574 -5875
=============================================
- Hits 32508 5302 -27206
+ Misses 33239 8557 -24682
+ Partials 3674 577 -3097
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `36.72% <0.00%> (-10.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/pulsar/client/impl/PulsarClientImpl.java](https://codecov.io/gh/apache/pulsar/pull/19048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1B1bHNhckNsaWVudEltcGwuamF2YQ==) | `44.63% <0.00%> (-0.17%)` | :arrow_down: |
| [.../org/apache/pulsar/client/impl/ConnectionPool.java](https://codecov.io/gh/apache/pulsar/pull/19048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0Nvbm5lY3Rpb25Qb29sLmphdmE=) | `37.43% <0.00%> (-1.03%)` | :arrow_down: |
| [...ava/org/apache/pulsar/broker/admin/v2/Brokers.java](https://codecov.io/gh/apache/pulsar/pull/19048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9Ccm9rZXJzLmphdmE=) | | |
| [...roker/service/schema/SchemaCompatibilityCheck.java](https://codecov.io/gh/apache/pulsar/pull/19048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9TY2hlbWFDb21wYXRpYmlsaXR5Q2hlY2suamF2YQ==) | | |
| [...ache/pulsar/broker/namespace/ServiceUnitUtils.java](https://codecov.io/gh/apache/pulsar/pull/19048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9uYW1lc3BhY2UvU2VydmljZVVuaXRVdGlscy5qYXZh) | | |
| [...ulsar/broker/namespace/NamespaceEphemeralData.java](https://codecov.io/gh/apache/pulsar/pull/19048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9uYW1lc3BhY2UvTmFtZXNwYWNlRXBoZW1lcmFsRGF0YS5qYXZh) | | |
| [...rvice/schema/KeyValueSchemaCompatibilityCheck.java](https://codecov.io/gh/apache/pulsar/pull/19048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9LZXlWYWx1ZVNjaGVtYUNvbXBhdGliaWxpdHlDaGVjay5qYXZh) | | |
| [.../apache/pulsar/proxy/server/AdminProxyHandler.java](https://codecov.io/gh/apache/pulsar/pull/19048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXByb3h5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvcHJveHkvc2VydmVyL0FkbWluUHJveHlIYW5kbGVyLmphdmE=) | | |
| [...he/pulsar/broker/intercept/BrokerInterceptors.java](https://codecov.io/gh/apache/pulsar/pull/19048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9pbnRlcmNlcHQvQnJva2VySW50ZXJjZXB0b3JzLmphdmE=) | | |
| [...r/broker/service/schema/AlwaysSchemaValidator.java](https://codecov.io/gh/apache/pulsar/pull/19048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9BbHdheXNTY2hlbWFWYWxpZGF0b3IuamF2YQ==) | | |
| ... and [492 more](https://codecov.io/gh/apache/pulsar/pull/19048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #19048:
URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1370444626
@yuruguo - this change likely needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #19048:
URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1364546729
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #19048:
URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1383591669
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #19048:
URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1364544710
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #19048: [improve][client] Add unified newTableView method in PulsarClient
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #19048:
URL: https://github.com/apache/pulsar/pull/19048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on PR #19048:
URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1364997159
@yuruguo Thanks for your contributions.
This is a breaking change for PulsarClient API, so could you please make a discussion in the mail list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #19048:
URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1383391121
@poorbarcode @liangyepianzhou I have started a discussion to dev mail and see more in [here](https://lists.apache.org/thread/w6vnk6cxh36j4p8oh9czdqlr5kqhdgb7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #19048:
URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1365080844
> @yuruguo Thanks for your contributions. This is a breaking change for PulsarClient API, so could you please make a discussion in the mail list?
@poorbarcode @liangyepianzhou Thanks for your reply.
> This changes the public API
This is a breaking change for PulsarClient API
It is recommended to use the new method `newTableView(Schema)` to replace the deprecated method `newTableViewBuilder(Schema)` although it can still be used in later release version, and both ultimately call the same method `new TableViewBuilderImpl<>(this, schema)`, so I understand this will not break.
```
@Override
@Deprecated
public <T> TableViewBuilder<T> newTableViewBuilder(Schema<T> schema) {
return new TableViewBuilderImpl<>(this, schema);
}
@Override
public <T> TableViewBuilder<T> newTableView(Schema<T> schema) {
return new TableViewBuilderImpl<>(this, schema);
}
```
> so could you please make a discussion in the mail list?
That's no problem and I can start a discussion at Pulsar Dev Mail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #19048:
URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1383793429
> We should also change the test to point to the new method `newTableView(Schema<T> schema)`
>
> And we should also add the test for the new added method `newTableView()`
Test has been modified and added, PTAL :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #19048:
URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1383518020
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org