[GitHub] [netbeans] ebarboni commented on a diff in pull request #4450: master apidoc links fixes (partial)

[GitBox <gi...@apache.org>]

ebarboni commented on code in PR #4450:
URL: https://github.com/apache/netbeans/pull/4450#discussion_r944722100


##########
nbbuild/javadoctools/template.xml:
##########
@@ -308,10 +353,14 @@ cause it to fail.
             <bottom>${javadoc.footer}</bottom>
             <!-- Avoid timestamp comments in _all_ html generated files, to reduce unnecessary git commits -->
             <arg value="-notimestamp" />
-            <arg value="--allow-script-in-comments" />
         </javadoc>
     </target>
-    
+
+    <target name="javadoc-exec-packages" depends="javadoc-init,javadoc-generate-references,javadoc-generate-overview,javadoc-exec-condition,javadoc-check-timestamps,javadoc-make-plain-title,javadoc-make-hyperlinked-title,javadoc-exec-condition,-javadoc-set-footer,-javadoc-exec-packages-jdk,-javadoc-exec-packages-nbjavac" unless="javadoc.exec.packages">
+        <!-- javadoc-exec-packages-jdk  -->
+        <!-- javadoc-exec-packages-nbjavac  -->
+    </target>
+

Review Comment:
   previous target javadoc-exec-packages depends on -javadoc-exec-packages-jdk and javadoc-exec-packages-nbjavac



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists